Skip to content

base-class should be abstract #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2014
Merged

base-class should be abstract #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d1ba6
baseclass should be abstract
Tasteful Aug 14, 2014
beaa425
baseclass should be abstract
Tasteful Aug 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tests/Nest.Tests.Integration/Core/Map/BaseMappingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
namespace Nest.Tests.Integration.Core.Map
{
[TestFixture]
public class BaseMappingTests : IntegrationTests
public abstract class BaseMappingTests : IntegrationTests
{
[TestFixtureSetUp]
public void Initialize()
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Nest.Tests.Unit/BaseJsonTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public static class UnitTestDefaults
public static readonly string DefaultIndex = "nest_test_data";
}

public class BaseJsonTests
public abstract class BaseJsonTests
{
protected readonly IConnectionSettingsValues _settings;
/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Nest.Tests.Unit/Core/AttributeBasedMap/BaseAttributeMappingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Nest.Tests.Unit.Core.AttributeBasedMap
{
public class BaseAttributeMappingTests : BaseJsonTests
public abstract class BaseAttributeMappingTests : BaseJsonTests
{
protected string CreateMapFor<T>() where T : class
{
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Nest.Tests.Unit/Core/Indices/Analysis/BaseAnalysisTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Nest.Tests.Unit.Core.Indices.Analysis.Tokenizers
{
[TestFixture]
public class BaseAnalysisTests : BaseJsonTests
public abstract class BaseAnalysisTests : BaseJsonTests
{
public IIndicesOperationResponse Analysis(Func<AnalysisDescriptor, AnalysisDescriptor> analysisSelector)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Tests/Nest.Tests.Unit/QueryParsers/BaseParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
namespace Nest.Tests.Unit.QueryParsers
{
[TestFixture]
public class BaseParserTests : BaseJsonTests
public abstract class BaseParserTests : BaseJsonTests
{
public ISearchRequest GetSearchDescriptorForQuery(Func<SearchDescriptor<ElasticsearchProject>, SearchDescriptor<ElasticsearchProject>> create)
{
Expand Down