Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
@technige What do you think? Can you approve the workflow so that we can see the tests pass? |
|
Looks like https://github.com/elastic/elasticsearch-php/blob/6d77eb5f69878fda0f7347ee2f937e1662063008/src/Elasticsearch/Common/EmptyLogger.php is implemeting |
|
@ruudk Just adding a quick acknowledgement that I've seen this, and I'll get back to you soon. |
|
To follow up, we have now added this to our internal TODO list for review. cc: @ezimuel |
|
See also the separate changes proposed in #1190. |
|
Just because I am french and annoying, +1 for this one, I tested the PR on my side and thanks for the work, all of you! |
|
Thanks @ruudk for this PR, I'm going to release it in |
No description provided.