add ClientBuilder->setConnectionParams() #506

Merged
merged 1 commit into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@Oliboy50
Contributor

Oliboy50 commented Nov 29, 2016

We want to be able to pass ['client'][] options globally instead of "per request".

This PR hopes to be merged in a 2.3.0 release (because I don't use 5.x yet). 馃懠
See #507 for master branch PR.

Related issues: #382 #259

@polyfractal

This comment has been minimized.

Show comment
Hide comment
@polyfractal

polyfractal Nov 29, 2016

Member

Thanks! LGTM. I was going to say I'd also forward-port this... but looks like you just did that in #507. 鉂わ笍

I'm stuck in a few meetings this morning, but I'll tag a new release ASAP so this can be used :)

Member

polyfractal commented Nov 29, 2016

Thanks! LGTM. I was going to say I'd also forward-port this... but looks like you just did that in #507. 鉂わ笍

I'm stuck in a few meetings this morning, but I'll tag a new release ASAP so this can be used :)

@polyfractal polyfractal merged commit e768e0d into elastic:2.0 Nov 29, 2016

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Oliboy50

This comment has been minimized.

Show comment
Hide comment
@Oliboy50

Oliboy50 Nov 29, 2016

Contributor

@polyfractal thanks a lot!
But it seems the Travis build fails on #507 ... but it doesn't seem to be related to my PR... because I have the exact same problem with this really really really simple PR: #504

Travis looks broken on the master branch =/

Contributor

Oliboy50 commented Nov 29, 2016

@polyfractal thanks a lot!
But it seems the Travis build fails on #507 ... but it doesn't seem to be related to my PR... because I have the exact same problem with this really really really simple PR: #504

Travis looks broken on the master branch =/

@Oliboy50 Oliboy50 referenced this pull request in M6Web/ElasticsearchBundle Nov 29, 2016

Merged

support ClientBuilder->setConnectionParams() #15

@polyfractal

This comment has been minimized.

Show comment
Hide comment
@polyfractal

polyfractal Nov 29, 2016

Member

Yep, travis is a bit broken atm. Been fighting it over the json extension... travis uses an older version which isn't compatible with JSON_PRESERVE_ZERO_FRACTION (you can see the recent commits on master have been travis-fighting)

Once I get a few minutes today I'm going to run #507 locally and verify, but I don't expect any problems on master either. :)

Member

polyfractal commented Nov 29, 2016

Yep, travis is a bit broken atm. Been fighting it over the json extension... travis uses an older version which isn't compatible with JSON_PRESERVE_ZERO_FRACTION (you can see the recent commits on master have been travis-fighting)

Once I get a few minutes today I'm going to run #507 locally and verify, but I don't expect any problems on master either. :)

@Oliboy50

This comment has been minimized.

Show comment
Hide comment
@Oliboy50

Oliboy50 Nov 29, 2016

Contributor

sounds fair 馃槂
the most important for me is to have a new release v2.x.x containing this commit 馃構

Contributor

Oliboy50 commented Nov 29, 2016

sounds fair 馃槂
the most important for me is to have a new release v2.x.x containing this commit 馃構

@Oliboy50

This comment has been minimized.

Show comment
Hide comment
@Oliboy50

Oliboy50 Nov 30, 2016

Contributor

@polyfractal Sorry to insist but do you think a new release for the 2.x branch including this new feature will be out soon?
I need this change but it's a PITA to use my fork instead of this official repository in my company's projects... so I prefer to do it only if you tell me that it will take a while 馃樋
Thanks anyway :)

Contributor

Oliboy50 commented Nov 30, 2016

@polyfractal Sorry to insist but do you think a new release for the 2.x branch including this new feature will be out soon?
I need this change but it's a PITA to use my fork instead of this official repository in my company's projects... so I prefer to do it only if you tell me that it will take a while 馃樋
Thanks anyway :)

@polyfractal

This comment has been minimized.

Show comment
Hide comment
@polyfractal

polyfractal Nov 30, 2016

Member

Just tagged as v2.3.0 which has this commit. Lemme know if you have any problems :)

Member

polyfractal commented Nov 30, 2016

Just tagged as v2.3.0 which has this commit. Lemme know if you have any problems :)

@Oliboy50 Oliboy50 deleted the M6Web:set-connection-params branch Nov 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment