add ClientBuilder->setConnectionParams() #507

Merged
merged 1 commit into from Dec 16, 2016

Conversation

Projects
None yet
3 participants
@Oliboy50
Contributor

Oliboy50 commented Nov 29, 2016

Closes #382

We want to be able to pass ['client'][] options globally instead of "per request".

This is the PR for the master branch, see #506 for 2.x branch.

Other related issues: #259

@polyfractal polyfractal merged commit 51afb31 into elastic:master Dec 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
CLA Commit author has signed the CLA
Details
@johntiror

This comment has been minimized.

Show comment
Hide comment
@johntiror

johntiror Jan 25, 2017

Hi, I couldn't find documentation regarding this new method. How can I set the timeout? like this?
$params['client']['timeout']=10;

Thanks

Hi, I couldn't find documentation regarding this new method. How can I set the timeout? like this?
$params['client']['timeout']=10;

Thanks

@polyfractal

This comment has been minimized.

Show comment
Hide comment
@polyfractal

polyfractal Jan 26, 2017

Member

@johntiror Yep!

There's also $params['client']['connect_timeout'] which controls the original connection timeout duration ('timeout' controls the request timeout, not the initial connection). Most folks don't really care which, but sometimes the distinction matters :)

Member

polyfractal commented Jan 26, 2017

@johntiror Yep!

There's also $params['client']['connect_timeout'] which controls the original connection timeout duration ('timeout' controls the request timeout, not the initial connection). Most folks don't really care which, but sometimes the distinction matters :)

p365labs added a commit to p365labs/elasticsearch-php that referenced this pull request Sep 10, 2017

p365labs added a commit to p365labs/elasticsearch-php that referenced this pull request Sep 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment