Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default metric='_all' to cluster.state() #1143

Merged
merged 6 commits into from Mar 10, 2020
Merged

Conversation

@sethmlarson
Copy link
Member

sethmlarson commented Mar 10, 2020

It looks like this little piece of logic was lost in the API auto-generation commit. I went through that commit and I didn't see any other special logic that was lost so we should be good now?
Should probably release a 7.5.2 with the past few commits and fixes.

Closes #1141

@sethmlarson sethmlarson requested a review from HonzaKral Mar 10, 2020
@@ -102,6 +102,9 @@ def state(self, metric=None, index=None, params=None):
:arg wait_for_timeout: The maximum time to wait for
wait_for_metadata_version before timing out
"""
if index and not metric:

This comment has been minimized.

Copy link
@HonzaKral

HonzaKral Mar 10, 2020

Member

I think just for consistency we might want to check against SKIP_IN_PATH instead of just the bool value. It amounts to the same thing in this case pretty much but would probably be better

This comment has been minimized.

Copy link
@sethmlarson

sethmlarson Mar 10, 2020

Author Member

Yeah agreed.

sethmlarson added 2 commits Mar 10, 2020
…to cluster-state-default
@sethmlarson sethmlarson added the 7.x label Mar 10, 2020
sethmlarson added 2 commits Mar 10, 2020
…ticsearch-py into cluster-state-default
@sethmlarson sethmlarson merged commit ef75a78 into master Mar 10, 2020
8 of 11 checks passed
8 of 11 checks passed
package
Details
package
Details
lint
Details
lint
Details
docs
Details
docs
Details
clients-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
CLA All commits passed the check
Details
elasticsearch-ci/docs Build finished.
Details
@sethmlarson sethmlarson deleted the cluster-state-default branch Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.