Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate article.rb-related content in expert template - caused ... #207

Closed
wants to merge 1 commit into from
Closed

Conversation

binaryphile
Copy link

...template install to fail

There was some repeated text in the expert template which was causing the install to fail.

It was attempting to add text to the article.rb file before that file existed. I excised the offending code.

@epologee
Copy link

bump.

The 03-expert.rb template still doesn't work, and in the mean time it seems more template rows have been added (like a gsub on a non-existing article_tests.rb file) that cause the template to still fail.

After removing the offending lines, the rails app will not start, with messages of an uninitialized constant:

.../searchapp/config/initializers/elasticsearch.rb:4:in `<top (required)>': uninitialized constant Elasticsearch (NameError)

@dabit
Copy link

dabit commented May 11, 2015

Are you running the templates in order?

The 02, 03... Templates won't run by themselves.

You have to run 01, then 02 on top of that, then 03 on top of that and so on.

@karmi
Copy link
Contributor

karmi commented May 22, 2015

@binaryphile @epologee Yeah, @dabit is right -- you have to run the templates on top of each other. Are you sure you run them like that?

I think there's maybe an issue already open to put some kind of guards there, which would enforce it, and fail loudly. I must look into that.

@epologee
Copy link

I was indeed not running the templates progressively. Haven't had the time to check, but I assume all will work as intended once I do so. Thanks for clearing this up.

@karmi
Copy link
Contributor

karmi commented May 26, 2015

@epologee Thanks! I'll put in some checks to prevent running the templates out of order, keeping this one open until it happens.

@tylerjl
Copy link
Contributor

tylerjl commented Apr 11, 2017

The templates now have checks to help steer people towards running these in order, so per @karmi's last comment I think we're good to close this now. 👍

@tylerjl tylerjl closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants