Validate updates #658
Closed
Validate updates #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any priority on getting this to pass CI and merged? IMO, this is a huge flaw in the |
hfenton
reviewed
Oct 11, 2017
| # @return [Hash] The Elasticsearch response as a Hash | ||
| # | ||
| def update(attributes={}, options={}) | ||
| attributes = self.attributes.merge(attributes) |
There was a problem hiding this comment.
This should be self.attributes = self.attributes.merge(attributes)
Contributor
|
I'm going to close this as it's no longer relevant. We have deprecated and removed the ActiveRecord persistence pattern in version 6.0 of the elasticsearch-persistence gem. Please consider migrating your app to use the repository pattern instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #450 and #289, the validation doesn't work when you make an update that makes a field invalid.
My knowledge in elasticsearch is very limited, so I am not sure if updating in line 115 works well with the attributes being passed directly in line 126. You might want to pass
self.attributesto update instead.