[MODEL] Ensure that specified ActiveRecord order is not overwritten by Elasticsearch search results order

[estolfo]

This pull request resolves the following issues

• [Model] Fix ActiveRecord sorted collection #618
• Sort order disobeyed #546

And is related to this pull request, which partially resolved the issue.
#831

[jazzytomato]

Looks good! I think we could even remove the code which redefines the to_a method to the original one?

elasticsearch-rails/elasticsearch-model/lib/elasticsearch/model/adapters/active_record.rb

Lines 57 to 77 in 0d236c8

	def order(*args)
	sql_records = records.__send__ :order, *args
	# Redefine the `to_a` method to the original one
	#
	sql_records.instance_exec do
	ar_records_method_name = :to_a
	ar_records_method_name = :records if defined?(::ActiveRecord) && ::ActiveRecord::VERSION::MAJOR >= 5
	define_singleton_method(ar_records_method_name) do
	if defined?(::ActiveRecord) && ::ActiveRecord::VERSION::MAJOR >= 4
	self.load
	else
	self.__send__(:exec_queries)
	end
	@records
	end
	end
	sql_records
	end

[estolfo]

@jazzytomato Good catch, I'll test it and see if we can remove that. Thanks for your review!

[estolfo]

@jazzytomato I've pushed another commit that removes the interception of #order, as it's not necessary with the check on order_values in the #records method. What do you think?