Splitting summary and description in OpenAPI output #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
suggested changes
Jun 7, 2024
Contributor
swallez
left a comment
swallez
left a comment
There was a problem hiding this comment.
I left lots of nitpicking comments to improve your Rust-fu 😉
Anaethelion
reviewed
Jun 7, 2024
Contributor
There was a problem hiding this comment.
Left some comments, looks cleaner with the segmenter.
Some of @swallez comments might still apply.
This was referenced Jun 12, 2024
swallez
approved these changes
Jun 17, 2024
Contributor
swallez
left a comment
swallez
left a comment
There was a problem hiding this comment.
LGTM once we handle the additional pathological case.
flobernd
pushed a commit
that referenced
this pull request
Jun 18, 2024
* test * further test * refactoring * linter * using segmenter to split sentences * removing newlines + unit test * comment * handled specific case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements:
summaryshould contain the first sentence ofdescription, whiledescriptionshould contain the remaining phrases.