From 3859857f4793720891b2f47aa87c0499ad52817c Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 13 Jun 2024 09:49:51 +0400 Subject: [PATCH 1/3] Fix generation output type check --- typescript-generator/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/typescript-generator/package.json b/typescript-generator/package.json index b3c0bdbe63..0dad5b09ec 100644 --- a/typescript-generator/package.json +++ b/typescript-generator/package.json @@ -10,7 +10,7 @@ "kibana": "KIBANA=true ts-node src/client.ts", "lint": "ts-standard src", "lint:fix": "ts-standard --fix src", - "is-valid-output": "tsc --noEmit", + "is-valid-output": "tsc --noEmit ../output/typescript/types.ts", "test": "npm run lint", "build": "rm -rf lib && tsc" }, From cf64fa85c2091647d2d8d71aedac481a027b79fa Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 13 Jun 2024 11:20:31 +0400 Subject: [PATCH 2/3] Generate in validate-pr workflow --- .github/workflows/validate-pr.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index 0b388ddc72..dfbcc12875 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -51,6 +51,11 @@ jobs: npm install --prefix .github/validate-pr make setup + - name: Generate specification and check generated types + working-directory: ./elasticsearch-specification + run: | + make generate + - name: Download artifacts working-directory: ./clients-flight-recorder run: | From 4253aab96f255390cc329217795fd539c846f74f Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 13 Jun 2024 11:26:19 +0400 Subject: [PATCH 3/3] Run validation even without validation changes --- .github/workflows/validate-pr.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/validate-pr.yml b/.github/workflows/validate-pr.yml index dfbcc12875..b76165ab4d 100644 --- a/.github/workflows/validate-pr.yml +++ b/.github/workflows/validate-pr.yml @@ -2,13 +2,6 @@ name: Validate APIs on: pull_request: - paths: - - 'specification/**' - - '!specification/_types/**' - - '!specification/_spec_utils/**' - - '!specification/_doc_ids/**' - - '!specification/_json_spec/**' - branches: - main