From 3095d165502a92bbfbfdc954fe8abbc34f216066 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Laurent=20Saint-F=C3=A9lix?= Date: Thu, 27 Mar 2025 18:08:41 +0100 Subject: [PATCH] Inference: rename base type, no longer a base, grown into a property (#4155) * Inference: rename base type, no longer a base, grown into a property * Making compiler happy by not extending request on a common type (cherry picked from commit 3afc61dbc34f6104a0d7213f22729507a83e9de3) --- specification/inference/_types/CommonTypes.ts | 3 +-- .../inference/chat_completion_unified/UnifiedRequest.ts | 4 ++-- .../post_eis_chat_completion/PostEisChatCompletionRequest.ts | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/specification/inference/_types/CommonTypes.ts b/specification/inference/_types/CommonTypes.ts index 4ab5ce909b..e7cec1d33d 100644 --- a/specification/inference/_types/CommonTypes.ts +++ b/specification/inference/_types/CommonTypes.ts @@ -19,11 +19,10 @@ import { RateLimitSetting } from '@inference/_types/Services' import { UserDefinedValue } from '@spec_utils/UserDefinedValue' -import { RequestBase } from '@_types/Base' import { Id } from '@_types/common' import { float, integer, long } from '@_types/Numeric' -export class RequestChatCompletionBase extends RequestBase { +export class RequestChatCompletion { /** * A list of objects representing the conversation. */ diff --git a/specification/inference/chat_completion_unified/UnifiedRequest.ts b/specification/inference/chat_completion_unified/UnifiedRequest.ts index a77f8e68c6..5999d5be5c 100644 --- a/specification/inference/chat_completion_unified/UnifiedRequest.ts +++ b/specification/inference/chat_completion_unified/UnifiedRequest.ts @@ -17,7 +17,7 @@ * under the License. */ -import { RequestChatCompletionBase } from '@inference/_types/CommonTypes' +import { RequestChatCompletion } from '@inference/_types/CommonTypes' import { RequestBase } from '@_types/Base' import { Id } from '@_types/common' import { Duration } from '@_types/Time' @@ -49,5 +49,5 @@ export interface Request extends RequestBase { timeout?: Duration } /** @codegen_name chat_completion_request */ - body: RequestChatCompletionBase + body: RequestChatCompletion } diff --git a/specification/inference/post_eis_chat_completion/PostEisChatCompletionRequest.ts b/specification/inference/post_eis_chat_completion/PostEisChatCompletionRequest.ts index 2ab19abf72..5141e37051 100644 --- a/specification/inference/post_eis_chat_completion/PostEisChatCompletionRequest.ts +++ b/specification/inference/post_eis_chat_completion/PostEisChatCompletionRequest.ts @@ -17,7 +17,7 @@ * under the License. */ -import { RequestChatCompletionBase } from '@inference/_types/CommonTypes' +import { RequestChatCompletion } from '@inference/_types/CommonTypes' import { RequestBase } from '@_types/Base' import { Id } from '@_types/common' /** @@ -44,5 +44,5 @@ export interface Request extends RequestBase { eis_inference_id: Id } /** @codegen_name chat_completion_request */ - body: RequestChatCompletionBase + body: RequestChatCompletion }