From 9d812bbb84defb0cf0957f52ed2a4e9fec2d5956 Mon Sep 17 00:00:00 2001 From: Mayya Sharipova Date: Mon, 31 Mar 2025 11:52:59 -0400 Subject: [PATCH 1/2] Clarify that min_score applies to aggs Relates to https://github.com/elastic/elasticsearch/pull/125882 --- specification/_global/search/SearchRequest.ts | 2 +- specification/_global/search/_types/SearchRequestBody.ts | 2 +- specification/async_search/submit/AsyncSearchSubmitRequest.ts | 2 +- specification/fleet/search/SearchRequest.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/specification/_global/search/SearchRequest.ts b/specification/_global/search/SearchRequest.ts index 49f77ea08d..cee2a0b5cc 100644 --- a/specification/_global/search/SearchRequest.ts +++ b/specification/_global/search/SearchRequest.ts @@ -448,7 +448,7 @@ export interface Request extends RequestBase { rank?: RankContainer /** * The minimum `_score` for matching documents. - * Documents with a lower `_score` are not included in the search results. + * Documents with a lower `_score` are not included in search results and results collected by aggregations. */ min_score?: double /** diff --git a/specification/_global/search/_types/SearchRequestBody.ts b/specification/_global/search/_types/SearchRequestBody.ts index f242db8bd7..373c1cc1b0 100644 --- a/specification/_global/search/_types/SearchRequestBody.ts +++ b/specification/_global/search/_types/SearchRequestBody.ts @@ -103,7 +103,7 @@ export class SearchRequestBody { rank?: RankContainer /** * The minimum `_score` for matching documents. - * Documents with a lower `_score` are not included in the search results. + * Documents with a lower `_score` are not included in search results or results collected by aggregations. */ min_score?: double /** diff --git a/specification/async_search/submit/AsyncSearchSubmitRequest.ts b/specification/async_search/submit/AsyncSearchSubmitRequest.ts index e57602debc..3e38180111 100644 --- a/specification/async_search/submit/AsyncSearchSubmitRequest.ts +++ b/specification/async_search/submit/AsyncSearchSubmitRequest.ts @@ -203,7 +203,7 @@ export interface Request extends RequestBase { knn?: KnnSearch | KnnSearch[] /** * Minimum _score for matching documents. Documents with a lower _score are - * not included in the search results. + * not included in search results and results collected by aggregations. */ min_score?: double post_filter?: QueryContainer diff --git a/specification/fleet/search/SearchRequest.ts b/specification/fleet/search/SearchRequest.ts index 63a4a73c73..40b57cf64c 100644 --- a/specification/fleet/search/SearchRequest.ts +++ b/specification/fleet/search/SearchRequest.ts @@ -175,7 +175,7 @@ export interface Request extends RequestBase { docvalue_fields?: FieldAndFormat[] /** * Minimum _score for matching documents. Documents with a lower _score are - * not included in the search results. + * not included in search results and results collected by aggregations. */ min_score?: double post_filter?: QueryContainer From 7924440b84438ff0feed2c3397c99c75a5b9e640 Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Thu, 3 Apr 2025 10:35:53 +0400 Subject: [PATCH 2/2] Run make contrib --- output/openapi/elasticsearch-openapi.json | 8 ++++---- output/openapi/elasticsearch-serverless-openapi.json | 6 +++--- output/schema/schema-serverless.json | 6 +++--- output/schema/schema.json | 8 ++++---- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/output/openapi/elasticsearch-openapi.json b/output/openapi/elasticsearch-openapi.json index 8429217e9f..edf6de93bb 100644 --- a/output/openapi/elasticsearch-openapi.json +++ b/output/openapi/elasticsearch-openapi.json @@ -50878,7 +50878,7 @@ "$ref": "#/components/schemas/_types:RankContainer" }, "min_score": { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results or results collected by aggregations.", "type": "number" }, "post_filter": { @@ -114643,7 +114643,7 @@ ] }, "min_score": { - "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in the search results.", + "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in search results and results collected by aggregations.", "type": "number" }, "post_filter": { @@ -115176,7 +115176,7 @@ } }, "min_score": { - "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in the search results.", + "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in search results and results collected by aggregations.", "type": "number" }, "post_filter": { @@ -116719,7 +116719,7 @@ "$ref": "#/components/schemas/_types:RankContainer" }, "min_score": { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results and results collected by aggregations.", "type": "number" }, "post_filter": { diff --git a/output/openapi/elasticsearch-serverless-openapi.json b/output/openapi/elasticsearch-serverless-openapi.json index 7636d00df4..848fff949b 100644 --- a/output/openapi/elasticsearch-serverless-openapi.json +++ b/output/openapi/elasticsearch-serverless-openapi.json @@ -30014,7 +30014,7 @@ ] }, "min_score": { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results or results collected by aggregations.", "type": "number" }, "post_filter": { @@ -68063,7 +68063,7 @@ ] }, "min_score": { - "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in the search results.", + "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in search results and results collected by aggregations.", "type": "number" }, "post_filter": { @@ -69421,7 +69421,7 @@ ] }, "min_score": { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results and results collected by aggregations.", "type": "number" }, "post_filter": { diff --git a/output/schema/schema-serverless.json b/output/schema/schema-serverless.json index 0249316eda..b245fa4a06 100644 --- a/output/schema/schema-serverless.json +++ b/output/schema/schema-serverless.json @@ -11932,7 +11932,7 @@ } }, { - "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in the search results.", + "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in search results and results collected by aggregations.", "name": "min_score", "required": false, "type": { @@ -42267,7 +42267,7 @@ } }, { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results and results collected by aggregations.", "name": "min_score", "required": false, "type": { @@ -52878,7 +52878,7 @@ } }, { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results or results collected by aggregations.", "name": "min_score", "required": false, "type": { diff --git a/output/schema/schema.json b/output/schema/schema.json index 4930646d2d..e8891dced1 100644 --- a/output/schema/schema.json +++ b/output/schema/schema.json @@ -35555,7 +35555,7 @@ } }, { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results and results collected by aggregations.", "name": "min_score", "required": false, "type": { @@ -41649,7 +41649,7 @@ } }, { - "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in the search results.", + "description": "The minimum `_score` for matching documents.\nDocuments with a lower `_score` are not included in search results or results collected by aggregations.", "name": "min_score", "required": false, "type": { @@ -92517,7 +92517,7 @@ } }, { - "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in the search results.", + "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in search results and results collected by aggregations.", "name": "min_score", "required": false, "type": { @@ -126831,7 +126831,7 @@ } }, { - "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in the search results.", + "description": "Minimum _score for matching documents. Documents with a lower _score are\nnot included in search results and results collected by aggregations.", "name": "min_score", "required": false, "type": {