From be67575c6637ce9da974b044980d3a539b25ec19 Mon Sep 17 00:00:00 2001 From: Quentin Pradet Date: Tue, 24 Jun 2025 14:33:21 +0400 Subject: [PATCH] Fix validation for _global APIs (#4659) The existing namespace computation was too naive. (cherry picked from commit bd228bbfc7c81a6e8a19b61eff0e517a7278456e) --- .github/validate-pr/index.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/validate-pr/index.js b/.github/validate-pr/index.js index 8ad71cbe6b..2ec385b2c1 100644 --- a/.github/validate-pr/index.js +++ b/.github/validate-pr/index.js @@ -105,7 +105,7 @@ async function run() { ci: false, verbose: false }) - const [namespace, _method] = api.split('.') + const namespace = getNamespace(api) // Asked to validate a specific API, so we only store that one reports.set(api, report.get(namespace)[0]) } @@ -120,7 +120,7 @@ async function run() { verbose: false }) - const [namespace, _method] = api.split('.') + const namespace = getNamespace(api) // Asked to validate a specific API, so we only store that one reports.set(api, report.get(namespace)[0]) } @@ -162,7 +162,6 @@ function getApi (file) { return file.split('/').slice(1, 3).filter(s => !privateNames.includes(s)).filter(Boolean).join('.') } - function findBaselineReport(apiName, baselineValidation) { const [namespace, method] = apiName.split('.')