Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround UJSON4C's parsing failure cause #108

Merged
merged 2 commits into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@bpintea
Copy link
Collaborator

commented Feb 1, 2019

UJSON4C will fail to parse an object if past the indicated length there's white space => add a 0-terminator.

(The entire parsing in the library is unsafe without this 0-term, actually.)

Close #61.

bpintea added some commits Feb 1, 2019

fix: 0-terminate the reply body/JSON object
UJSON4C will fail to parse an object if past the indicated lenght
there's white space => add a 0-terminator.

(The entire parsing in the library is unsafe without this 0-term,
actually.)
@droberts195
Copy link
Collaborator

left a comment

LGTM

@bpintea bpintea merged commit 6da03f0 into elastic:master Feb 1, 2019

@bpintea bpintea deleted the bpintea:fix/ujson4c_fail_on_ws branch Feb 1, 2019

bpintea added a commit that referenced this pull request Feb 1, 2019

Workaround UJSON4C's parsing failure cause (#108)
* fix: 0-terminate the reply body/JSON object

UJSON4C will fail to parse an object if past the indicated lenght
there's white space => add a 0-terminator.

(The entire parsing in the library is unsafe without this 0-term,
actually.)

* undo #62 attempt

(cherry picked from commit 6da03f0)

bpintea added a commit that referenced this pull request Feb 1, 2019

Workaround UJSON4C's parsing failure cause (#108)
* fix: 0-terminate the reply body/JSON object

UJSON4C will fail to parse an object if past the indicated lenght
there's white space => add a 0-terminator.

(The entire parsing in the library is unsafe without this 0-term,
actually.)

* undo #62 attempt

(cherry picked from commit 6da03f0)

@bpintea bpintea added >bug and removed fix labels May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.