Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: add Kibana's sample data to the tests #123

Merged
merged 2 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@bpintea
Copy link
Collaborator

commented Mar 6, 2019

This PR will load and use Kibana's sample data sets for the integration testing:

  • index the currently three data sets into the local node;
  • select and fetch all the columns from the "flights" set.

The "ecommerce" and "logs" sets require server-side changes to be able to use them (i.e. dealing with array fields).

add Kibana's sample data to the tests
- index the data used by Kibana as sample data into the local node;
- select and fetch all the columns from the "flights" set;

- "ecommerce" and "logs" require server-side changes to be able to use
them.

@bpintea bpintea requested review from droberts195 and edsavage Mar 6, 2019

@@ -143,6 +145,9 @@

ES_DATASET_BASE_URL = "https://raw.githubusercontent.com/elastic/elasticsearch/6857d305270be3d987689fda37cc84b7bc18fbb3/x-pack/plugin/sql/qa/src/main/resources/"

KIBANA_SAMPLES_BASE_URL = "https://raw.githubusercontent.com/elastic/kibana/master/src/legacy/server/sample_data/data_sets"

This comment has been minimized.

Copy link
@droberts195

droberts195 Mar 6, 2019

Collaborator

Here you're using the master branch whereas for the ES data set above you used a specific commit.

Have you considered using a specific commit for Kibana too? If you use master they can break your tests by changing the data and/or directory structure, forcing you to react immediately. Whereas if you use a specific commit you can just update it once per year at a time of your choosing.

This comment has been minimized.

Copy link
@bpintea

bpintea Mar 6, 2019

Author Collaborator

Thanks, I've changed it to stay consistent.
(My late thought was to be "notified" quickly on data set change, but otoh it does seem that Kibana's folder structure might change.)

@droberts195
Copy link
Collaborator

left a comment

LGTM

@bpintea bpintea merged commit b6002cd into elastic:master Mar 6, 2019

@bpintea bpintea deleted the bpintea:test/kibana_sample_data branch Mar 6, 2019

bpintea added a commit that referenced this pull request Mar 6, 2019

Test: add Kibana's sample data to the tests (#123)
* add Kibana's sample data to the tests

- index the data used by Kibana as sample data into the local node;
- select and fetch all the columns from the "flights" set;

- "ecommerce" and "logs" require server-side changes to be able to use
them.

* pin kibana sample data source to specific commit

(cherry picked from commit b6002cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.