Drop static buffer usage for cursor in requests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cursor received from ES/SQL is being sent back to it when fetching the next result set "page". When building the request, it's value was converted from SQLWCHAR to mb-string in a static buffer, to find out first the space required for it in the request. Since the cursor value is a Base64 encoding string, the conversion can simply be done by ASCII conversion, and thus the buffer is no longer needed. This fixes the case where the cursor value received from ES/SQL goes over the buffer size (4KB), thus generating a failed query.
bpintea
added a commit
that referenced
this pull request
Jan 17, 2019
The cursor received from ES/SQL is being sent back to it when fetching the next result set "page". When building the request, it's value was converted from SQLWCHAR to mb-string in a static buffer, to find out first the space required for it in the request. Since the cursor value is a Base64 encoding string, the conversion can simply be done by ASCII conversion, and thus the buffer is no longer needed. This fixes the case where the cursor value received from ES/SQL goes over the buffer size (4KB), thus generating a failed query. (cherry picked from commit 6f5d33d)
bpintea
added a commit
that referenced
this pull request
Jan 17, 2019
The cursor received from ES/SQL is being sent back to it when fetching the next result set "page". When building the request, it's value was converted from SQLWCHAR to mb-string in a static buffer, to find out first the space required for it in the request. Since the cursor value is a Base64 encoding string, the conversion can simply be done by ASCII conversion, and thus the buffer is no longer needed. This fixes the case where the cursor value received from ES/SQL goes over the buffer size (4KB), thus generating a failed query. (cherry picked from commit 6f5d33d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor received from ES/SQL is being sent back to it when fetching
the next result set "page". When building the request, it's value was
converted from SQLWCHAR to mb-string in a static buffer, to find out
first the space required for it in the request.
Since the cursor value is a Base64 encoding string, the conversion can
simply be done by ASCII conversion, and thus the buffer is no longer
needed.
This fixes the case where the cursor value received from ES/SQL goes
over the buffer size (4KB), thus generating a failed query.
Close #86