Fix tokenizer serialization in AnalyzeRequest.toXContent() (#42795)

Fixes #39670
elastic · Jun 4, 2019 · 2f485b8 · 2f485b8
1 parent 30150b4
commit 2f485b8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/client/rest-high-level/src/test/java/org/elasticsearch/client/RequestConvertersTests.java b/client/rest-high-level/src/test/java/org/elasticsearch/client/RequestConvertersTests.java
@@ -1494,6 +1494,17 @@ public void testAnalyzeRequest() throws Exception {
         assertThat(RequestConverters.analyze(analyzeRequest).getEndpoint(), equalTo("/_analyze"));
     }
 
+    public void testAnalyzeRequestWithCustomAnalyzer() throws IOException {
+        AnalyzeRequest ar = new AnalyzeRequest()
+            .text("Here is some text")
+            .index("test_index")
+            .tokenizer("standard");
+
+        Request request = RequestConverters.analyze(ar);
+        assertThat(request.getEndpoint(), equalTo("/test_index/_analyze"));
+        assertToXContentBody(ar, request.getEntity());
+    }
+
     public void testGetScriptRequest() {
         GetStoredScriptRequest getStoredScriptRequest = new GetStoredScriptRequest("x-script");
         Map<String, String> expectedParams = new HashMap<>();

diff --git a/server/src/main/java/org/elasticsearch/action/admin/indices/analyze/AnalyzeRequest.java b/server/src/main/java/org/elasticsearch/action/admin/indices/analyze/AnalyzeRequest.java
@@ -281,7 +281,7 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
             builder.field("analyzer", analyzer);
         }
         if (tokenizer != null) {
-            tokenizer.toXContent(builder, params);
+            builder.field("tokenizer", tokenizer);
         }
         if (tokenFilters.size() > 0) {
             builder.field("filter", tokenFilters);