-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fielddata: Switch to Lucene DV APIs.
This commits removes BytesValues/LongValues/DoubleValues/... and tries to use Lucene's APIs such as NumericDocValues or RandomAccessOrds instead whenever possible. The next step would be to take advantage of the fact that APIs are the same in Lucene and Elasticsearch in order to remove our custom comparators and use Lucene's. There are a few side-effects to this change: - GeoDistanceComparator has been removed, DoubleValuesComparator is used instead on top of dynamically computed values (was easier than migrating GeoDistanceComparator). - SortedNumericDocValues doesn't guarantee uniqueness so long/double terms aggregators have been updated to make sure a document cannot fall twice in the same bucket. - Sorting by maximum value of a field or running a `max` aggregation is potentially significantly faster thanks to the random-access API. Our aggs and p/c aggregations benchmarks don't report differences with this change on uninverted field data. However the fact that doc values don't need to be wrapped anymore seems to help a lot. For example TermsAggregationSearchBenchmark reports ~30% faster terms aggregations on doc values on string fields with this change, which are now only ~18% slower than uninverted field data although stored on disk. Close #6908
- Loading branch information
Showing
202 changed files
with
4,964 additions
and
6,294 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 changes: 0 additions & 90 deletions
90
src/main/java/org/elasticsearch/index/fielddata/AbstractAtomicNumericFieldData.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.