Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log template management requests at INFO level #10795

Closed
ppf2 opened this issue Apr 24, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@ppf2
Copy link
Member

commented Apr 24, 2015

It will be helpful to move template management task entries (create, delete, update, etc..) from DEBUG to INFO level:

[2015-04-24 12:21:19,747][DEBUG][cluster.service          ] [Stiletto] processing [create-index-template [ls_template2], cause [api]]: execute
[2015-04-24 12:21:19,748][DEBUG][cluster.service          ] [Stiletto] cluster state updated, version [12], source [create-index-template [ls_template2], cause [api]]

@ppf2 ppf2 changed the title Log create template request at INFO level Log template management requests at INFO level Apr 24, 2015

@clintongormley

This comment has been minimized.

Copy link
Member

commented Apr 26, 2015

Or possibly provide a different context for logging, eg cluster.service.template?

@ppf2

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2015

Sounds like a good idea to create a new context and write some useful INFO level messages to this new logger. thx

@javanna

This comment has been minimized.

Copy link
Member

commented May 8, 2015

We discussed this during fixit-friday, we shouldn't go and change the log level for those existing lines, because they get logged for every single cluster state updates, which would make logs way too big at INFO level. But we can add additional log lines specifically to the create/remove index template code though if needed e.g. MetaDataIndexTemplateService similar to what MetaDataCreateIndexService does when an index gets created. We should do that for both removeTemplates & putTemplate methods. I think this is reasonable and wouldn't cause problems at INFO level, assuming that index templates don't get changed all the time.

kblincoe added a commit to kblincoe/elasticsearch that referenced this issue Mar 23, 2017

Enhaloed added a commit to Enhaloed/elasticsearch that referenced this issue Mar 24, 2017

kblincoe added a commit to kblincoe/elasticsearch that referenced this issue Mar 24, 2017

@jasontedor jasontedor removed the help wanted label Mar 13, 2018

@jasontedor

This comment has been minimized.

Copy link
Member

commented Mar 13, 2018

I opened #29027.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.