Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginManager should not install a plugin, if it would create jar hell #11946

Closed
rmuir opened this issue Jun 30, 2015 · 0 comments

Comments

@rmuir
Copy link
Contributor

commented Jun 30, 2015

We now fail on ES startup if we detect jar hell (which we should keep), but I think we can probably factor out the logic to a method that takes URL[]. pluginmanager could then pass classpath of current plugins, and add the "candidate" classpath from the plugin to-be-installed.

Ideally we do all of this before touching the filesystem, so the plugin installation just fails but the overall ES installation stays working.

I will try to make a prototype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.