Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same setting with different values in elasticsearch.yml should be an error #13079

Closed
mikemccand opened this issue Aug 24, 2015 · 3 comments

Comments

@mikemccand
Copy link
Contributor

commented Aug 24, 2015

I hit this while smoke testing the 2.0.0 beta RC.

Today, if you have the same setting in config/elasticsearch.yml more than once, I think the last one silently "wins".

But I think this is too lenient/trappy? E.g. someone may open the file, insert what they think is a new setting, but then it doesn't "take" because that setting already appears later in the file.

I think we should make this a hard error on startup instead.

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2015

+1

@rjernst

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

+1

Not only for different values, but the same setting twice should be an error too. We should fail early, before the user tries to change the setting (in just one place) and then hits the proposed error here.

@mikemccand

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2015

Not only for different values, but the same setting twice should be an error too. We should fail early,

++

@jasontedor jasontedor self-assigned this Aug 24, 2015
@jasontedor jasontedor added the v2.0.0 label Aug 24, 2015
jasontedor added a commit that referenced this issue Aug 25, 2015
This commit backports the fix #13086 for #13079 to 2.0 from master.
@clintongormley clintongormley added v2.0.0-beta2 and removed v2.0.0 labels Sep 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.