Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external versioning for deletes arriving before initial update #1351

Closed
jfiedler opened this issue Sep 21, 2011 · 3 comments

Comments

@jfiedler
Copy link
Contributor

commented Sep 21, 2011

The versioning feature works well for protecting the index against stale updates due to message reordering (e.g. in a messaging system). However, there is one case not handled properly yet which is when a delete (with external version number) arrives before the first update of the document (with external version number).

Find more on that in this group thread (that asked to file this as enhancement request): https://groups.google.com/d/topic/elasticsearch/QXn1wK01THE/discussion

@kimchy

This comment has been minimized.

Copy link
Member

commented Sep 21, 2011

Already fixed here #1341 :)

@kimchy kimchy closed this Sep 21, 2011

@jfiedler

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2011

I moved to 0.17.7 but my little test case is still red. Not sure #1341 really is the same as this issue. This is my test case: I trigger a delete with external version number 2 and then trigger an update with external version 1 (simulating message reordering). I am expecting the update to fail with a version conflict exception but it does succeed. When debugging I see the delete failing with a version conflict (current -1 but expected 2). The update then succeeds.

@kimchy kimchy reopened this Sep 22, 2011

@kimchy

This comment has been minimized.

Copy link
Member

commented Sep 22, 2011

Yea, you are right, I missed that interaction model, will fix.

@kimchy kimchy closed this in d76d7d4 Sep 22, 2011

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.