Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
We currently have a very large maven build system, comprising of 6k lines of xml. While maven parent POMs have been very useful in de-duplicating build logic across elasticsearch and plugins, the rigidity of maven has required us to begin implementing most of our test logic through
I have a branch which contains elasticsearch switched to using gradle:
This is a tracking issue for completing the migration to gradle. The tasks are separated into two groups: those remaining required before pushing to master (as to not completely break development), and those required for the migration to be complete, which must happen before the next release (tentatively 2.2).
Required for master push:
Required for release:
Addtional nice to haves:
You should probably add some of this to the pre-merge checklist to. Maybe just the some basic build instructions and a big note saying "
I'm cool with grabbing these later this week. If anyone that wants them before I get to them then please take them with my best wishes.
I'm cool with grabbing this later, maybe porting github.com/wikimedia/search-highlighter or something to prove it out.
I published a snapshot of the
Hmm .. since 2.x, the licenses are managed in https://github.com/elastic/elasticsearch/tree/2.1/distribution/licenses and some if not all libraries are not shaded, this pretty much invalidate pre 2.x auditing workflo, gradle 3rd party dependencies therefore is nice to have but not necessary.
Auditing will be
@rjernst I'm curious did you not know about
From maven: https://maven.apache.org/pom.html#Inheritance
Thus if you had put the relative path to your parent pom in your submodules maven would not have to go "download" the internet.
I only bring this up because I have people point to your gradle video about how the maven reactor won't let them build a part of the project without downloading other modules and thus fundamentally flawed.
EDIT: Oh I thought your parent was in a non standard directory. I guess you mean it goes and downloads snapshot pom files. There are ways around that but yes that is the reactor behavior.