Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Low Disk Watermark Logging Oddness #14194
Using a 2.0.0-snapshot build, I see odd logging behavior for the low disk watermark.
The free-disk calculation is working fine, but the logging for this is quite odd. After starting a single-node cluster with 5 shards (each with 1 shard, and 1 unassigned replica), I see several log messages about low disk watermark all at once. 30 seconds later, I see another group of low disk watermark messages, but each time there are more messages than previously. First time was 4 identical log lines, then 7, then 10, then 13.
I was able to reproduce several times after restarting the nodes. I inserted newlines into the excerpted logs below. This could become a real problem if the trend continues.
@skearns64 When I try to reproduce this, I am getting only a single logging message (extra spacing added by me):
You mentioned using a 2.0.0-snapshot build, what SHA are you building? I am building from the 2.0 branch, e1a7cc2.
The ExtensionPoint.ClassSet binds adds the extension classes to a a Multibinder and binds the classes and calls the asEagerSingleton method on the multibinder. This does not actually create a singleton. Instead we first bind the class as a singleton and add then add the class to the multibinder. Closes elastic#14194
More info on this. The multiple logging lines is caused by