New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "size": 0 for Term Facet #1776

Closed
ctrochalakis opened this Issue Mar 9, 2012 · 31 comments

Comments

Projects
None yet
@ctrochalakis

Is it possible to add support for setting "size": 0 to simple Term Facets in order to return all terms matching the hits?

This should be similar to the TermsStats Facet api.

@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Mar 9, 2012

Member

Yes, its definitely possible. I plan to do some refactoring in this area, once its done, we can then add this.

Member

kimchy commented Mar 9, 2012

Yes, its definitely possible. I plan to do some refactoring in this area, once its done, we can then add this.

@ctrochalakis

This comment has been minimized.

Show comment
Hide comment
@ctrochalakis

ctrochalakis Mar 10, 2012

Great, keep up the good work :)

Great, keep up the good work :)

@daetal-us

This comment has been minimized.

Show comment
Hide comment
@daetal-us

daetal-us Mar 10, 2012

Excellent.

Just wanted to give a big thumb up (two, even!) to this idea.

also, when implemented this might also close #1530

Excellent.

Just wanted to give a big thumb up (two, even!) to this idea.

also, when implemented this might also close #1530

@TLoD-Snake

This comment has been minimized.

Show comment
Hide comment
@TLoD-Snake

TLoD-Snake Mar 17, 2012

+1 vote for this feature!

+1 vote for this feature!

@jzelez

This comment has been minimized.

Show comment
Hide comment

jzelez commented Apr 12, 2012

+1

@edwardsmit

This comment has been minimized.

Show comment
Hide comment
@edwardsmit

edwardsmit May 1, 2012

+1 vote for this feature

+1 vote for this feature

@michaelirey

This comment has been minimized.

Show comment
Hide comment
@michaelirey

michaelirey Sep 5, 2012

Loving elasticsearch... I would really benefit from this feature. Any update on the status of this issue?

Loving elasticsearch... I would really benefit from this feature. Any update on the status of this issue?

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 5, 2012

Haven't had a chance to look at the issue, but past experience with earlier lucene and ESP, would suggest you are asking for a 0 to represent a null entry? Is that really what is meant?

On Sep 5, 2012, at 2:06 PM, Michael Irey wrote:

Loving elasticsearch... I would really benefit from this feature. Any update on the status of this issue?


Reply to this email directly or view it on GitHub.

ghost commented Sep 5, 2012

Haven't had a chance to look at the issue, but past experience with earlier lucene and ESP, would suggest you are asking for a 0 to represent a null entry? Is that really what is meant?

On Sep 5, 2012, at 2:06 PM, Michael Irey wrote:

Loving elasticsearch... I would really benefit from this feature. Any update on the status of this issue?


Reply to this email directly or view it on GitHub.

@michaelirey

This comment has been minimized.

Show comment
Hide comment
@michaelirey

michaelirey Sep 5, 2012

Really just looking for a way to ask for all facets to be returned... Perhaps omitting the the size param or having it set to all. Right now I have it set to a really high number. See: http://stackoverflow.com/questions/12285371/elasticsearch-number-of-facets-returned

Really just looking for a way to ask for all facets to be returned... Perhaps omitting the the size param or having it set to all. Right now I have it set to a really high number. See: http://stackoverflow.com/questions/12285371/elasticsearch-number-of-facets-returned

@MrJohnsson77

This comment has been minimized.

Show comment
Hide comment

+1

@jperelli

This comment has been minimized.

Show comment
Hide comment
@jperelli

jperelli Oct 2, 2012

Why is this issue open and documentation says: "The size parameter controls how many facet entries will be returned. It defaults to 10. Setting it to 0 will return all terms matching the hits"?
http://www.elasticsearch.org/guide/reference/api/search/facets/terms-stats-facet.html
What is the truly behavior?

jperelli commented Oct 2, 2012

Why is this issue open and documentation says: "The size parameter controls how many facet entries will be returned. It defaults to 10. Setting it to 0 will return all terms matching the hits"?
http://www.elasticsearch.org/guide/reference/api/search/facets/terms-stats-facet.html
What is the truly behavior?

@tikitu

This comment has been minimized.

Show comment
Hide comment
@tikitu

tikitu Oct 9, 2012

@jperelli the docs you're looking at are for the terms stats facet, not the terms facet: in the terms facet setting size to 0 just gives you no terms back.

tikitu commented Oct 9, 2012

@jperelli the docs you're looking at are for the terms stats facet, not the terms facet: in the terms facet setting size to 0 just gives you no terms back.

@jperelli

This comment has been minimized.

Show comment
Hide comment
@jperelli

jperelli Oct 9, 2012

You are right, in a closer look, I confused this issue with that part of the docs. Sorry!

jperelli commented Oct 9, 2012

You are right, in a closer look, I confused this issue with that part of the docs. Sorry!

@gjb83

This comment has been minimized.

Show comment
Hide comment

gjb83 commented Dec 20, 2012

+1

@pvulgaris

This comment has been minimized.

Show comment
Hide comment

+1

@kimchy

This comment has been minimized.

Show comment
Hide comment
@kimchy

kimchy Jan 4, 2013

Member

Fellows, just an update, its high on our prio list!, we are going to go through the mentioned refactoring and implement it. Its simpler now with Lucene 4 upgrade effectively done.

Member

kimchy commented Jan 4, 2013

Fellows, just an update, its high on our prio list!, we are going to go through the mentioned refactoring and implement it. Its simpler now with Lucene 4 upgrade effectively done.

@ZogStriP

This comment has been minimized.

Show comment
Hide comment

👍

@tfreitas

This comment has been minimized.

Show comment
Hide comment

+1

@pjrt

This comment has been minimized.

Show comment
Hide comment

pjrt commented Mar 3, 2013

+!

@fmardini

This comment has been minimized.

Show comment
Hide comment

+1

@pjrt

This comment has been minimized.

Show comment
Hide comment
@pjrt

pjrt Mar 15, 2013

Isn't this already implemented with the "all_terms" option?

pjrt commented Mar 15, 2013

Isn't this already implemented with the "all_terms" option?

@tikitu

This comment has been minimized.

Show comment
Hide comment
@tikitu

tikitu Mar 20, 2013

@pjrt: Nope. The "all_terms" option says "also include in the list terms that appear somewhere in the index for this field but that have no hits in this query" (i.e., entries with a count of zero). But the "size" parameter says "how many items from the top of the list should I actually return?"

On 15 mrt. 2013, at 18:16, Pedro Rodriguez notifications@github.com wrote:

Isn't this already implemented with the "all_terms" option?


Reply to this email directly or view it on GitHub.

tikitu commented Mar 20, 2013

@pjrt: Nope. The "all_terms" option says "also include in the list terms that appear somewhere in the index for this field but that have no hits in this query" (i.e., entries with a count of zero). But the "size" parameter says "how many items from the top of the list should I actually return?"

On 15 mrt. 2013, at 18:16, Pedro Rodriguez notifications@github.com wrote:

Isn't this already implemented with the "all_terms" option?


Reply to this email directly or view it on GitHub.

@nickstreet

This comment has been minimized.

Show comment
Hide comment

+1 👍

@trenpixster

This comment has been minimized.

Show comment
Hide comment

+1

@quentin389

This comment has been minimized.

Show comment
Hide comment

+1

@joafeldmann

This comment has been minimized.

Show comment
Hide comment
@joafeldmann

joafeldmann Sep 30, 2013

Since there is a "size" field, is it possible to also have a "from" field to paginate through facets?

Since there is a "size" field, is it possible to also have a "from" field to paginate through facets?

@taijinlee

This comment has been minimized.

Show comment
Hide comment

+1

@JohanTan

This comment has been minimized.

Show comment
Hide comment

JohanTan commented Nov 8, 2013

+1

@mbedna

This comment has been minimized.

Show comment
Hide comment

mbedna commented Nov 19, 2013

+1

@bobrik

This comment has been minimized.

Show comment
Hide comment
@bobrik

bobrik Dec 2, 2013

Contributor

Any updates? @kimchy said about priority list 11 months ago :)

I noticed weird thing today: all_terms with terms_stats returns all terms, but with terms facet you should specify size explicitly.

I guess this is not going to happen, aggregations are coming.

Contributor

bobrik commented Dec 2, 2013

Any updates? @kimchy said about priority list 11 months ago :)

I noticed weird thing today: all_terms with terms_stats returns all terms, but with terms facet you should specify size explicitly.

I guess this is not going to happen, aggregations are coming.

@dweiss

This comment has been minimized.

Show comment
Hide comment
Contributor

dweiss commented Jan 21, 2014

@jpountz

This comment has been minimized.

Show comment
Hide comment
@jpountz

jpountz Jan 22, 2014

Contributor

This feature has been implemented on aggregations (#4837). I am closing this issue as we are not going to modify facets anymore in order to focus on aggregations.

Contributor

jpountz commented Jan 22, 2014

This feature has been implemented on aggregations (#4837). I am closing this issue as we are not going to modify facets anymore in order to focus on aggregations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment