New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Histogram with extended bounds misses daylight savings date when no records matched #18310
Comments
@colings86 please could you take a look at this? |
Looking deeper in to this I realise that the intention is for one bucket for the hour covering the DST change over.
What you see here is a two streams in a channel, one from 31/3/2016 11:00 to 02/05/2016 14:00, and one from 02/05/2016 13:00 to 02/05/2016 14:00:00. Heres the full query I execute.
|
Further thought leads me to think the k=0 stream is correct because it's dst values were created by extended bounds, and the second failed because it actually had data. |
@mattdawson can you take a look at #18326 and the fix provided in #18415 to see if this solves your problem? I have looked at the queries you are using and this looks very similar, however I'm not fully able to understand your use case or check this with the patch from #18415 without a better understanding of your data. If looking at the two issues I linked to doesn't help, can you provide a minimal example with a few datapoints? |
@cbuescher, The code change appears to add one non-DST adjusted unit inside TimeUnitRounding .nextRoundingValue for intervals less than 1 day. Although the outcome is a consistent dual bucket for both extended and non-extended result sets, I believe it's the wrong approach. What you want is a single bucket covering 2 hours for the DST change over. The reason being because some DST change overs are only 30mins and this method would not be congruous between 1hour and 30min DST changes. |
@cbuescher,
|
@matsondawson This is a different problem unrelated to #18415 , although from a user perspective it appears related. If you use 15 min intevals, ES is using |
Closing due to lack of feedback. |
Elasticsearch version: 2.3.2
JVM version: 1.8.0_40-b25
OS version: Windows 7 Home Premium
Description of the problem including expected versus actual behavior:
Doing histo query over range with no matched data with extended bounds returns only 1 bucket on the daylight savings cross over for 2 hours. When this is done with matching data you get 2 buckets, 1 for pre-dst one for post dst both with same formatted time (0300hrs). It should consistently return 2 buckets or 1 bucket at crossover, which ever is correct.
Steps to reproduce:
Do a histo query with extended bounds on an index over a date range with no data over a daylight savings boundary. Then do one with data and compare results around April 3rd 3am, 2016
e.g.
The text was updated successfully, but these errors were encountered: