Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding `date_detection: false` to an existing _type returns `"acknowledged": true`, but does not get added. #20111

Closed
jpcarey opened this issue Aug 22, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@jpcarey
Copy link
Member

commented Aug 22, 2016

Elasticsearch version: 2.3.5
JVM version:

java version "1.8.0_65"
Java(TM) SE Runtime Environment (build 1.8.0_65-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.65-b01, mixed mode)

Description of the problem including expected versus actual behavior:
adding date_detection: false to an existing _type returns "acknowledged": true, but does not actually get added.

Steps to reproduce:

POST test2
PUT test2/_mapping/test
{
  "properties": {
    "date": {
      "type": "string"
    }
  }
}
POST test2/test
{ "date": "2014-01-01" }

PUT test2/_mapping/test
{
  "date_detection": false
}
GET test2/_mapping
@jpountz

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2016

This reproduces on master too, and interestingly it seems that this never worked. I opened a pull request to make it work (#20119), but I'm tempted to make it a 5.0-only change to be safe since this never worked before.

@jpcarey

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2016

@jpountz I have no pressing need since I only stumbled across this, so 5.0-only is fine by me.

jpountz added a commit to jpountz/elasticsearch that referenced this issue Aug 25, 2016

The root object mapper should support updating `numeric_detection`, `…
…date_detection` and `dynamic_date_formats`. elastic#20119

If they are specified by a mapping update, these properties are currently
ignored. This commit also fixes the handling of `dynamic_templates` so that it
is possible to remove templates (and so that it works more similarly to all
other mapping properties).

Closes elastic#20111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.