Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node name to decider trace logging #20379

Closed
ppf2 opened this issue Sep 8, 2016 · 5 comments

Comments

Projects
None yet
6 participants
@ppf2
Copy link
Member

commented Sep 8, 2016

The allocation decider logging at TRACE level can sometimes be helpful to determine why a shard is not getting allocated on specific nodes. Currently, we only log the node id for these messages. It will be helpful to also include the node name (esp. when dealing with a lot of nodes in the cluster).

@makeyang

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2016

I checked the code and found out that it's mainly logged only with node name, like below code:
logger.warn("Unable to retrieve node FS stats for {}", nodeStats.getNode().getName());
logger.trace("sending diff cluster state version [{}] with size {} to [{}]", clusterState.version(), clusterStateDiffBytes.length, discovery.localNode().getName());

so how about we only log node name here ?
if u guys agree with this, I'd like to fix it this way

@clintongormley

This comment has been minimized.

Copy link
Member

commented Sep 9, 2016

@bleskes @dakrone thoughts?

@dakrone

This comment has been minimized.

Copy link
Member

commented Sep 12, 2016

I don't think it'd be bad to add the name, should be a very small change to do

@bleskes

This comment has been minimized.

Copy link
Member

commented Sep 12, 2016

It's trace logging, which typically means the more information you have, the better. I would say just log the whole DiscoveryNode object

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2016

fixed by #20437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.