Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signer setting in aws plugins #22599

Closed
rjernst opened this issue Jan 12, 2017 · 2 comments · Fixed by #23984

Comments

@rjernst
Copy link
Member

commented Jan 12, 2017

We have a signer setting in our aws plugins, which overrides the signing type used to sign aws requests. However, this is completely untested, and is only needed for third party aws replacement apis like ceph. I think we should remove this setting, since it is untested and unsupported, and let the community fork the plugins to customize them for ceph, if there is demand.

@dadoonet

This comment has been minimized.

Copy link
Member

commented Jan 12, 2017

Agreed.

@clintongormley

This comment has been minimized.

Copy link
Member

commented Jan 14, 2017

This is a breaking change so let's do it for 6.0 only (and deprecation logging for 5.x)

rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 7, 2017
AWS Plugins: Remove signer type setting
This commit removes support for s3 signer type in 6.0, and adds a note
to the migration guide.

closes elastic#22599
rjernst added a commit that referenced this issue Apr 7, 2017
AWS Plugins: Remove signer type setting (#23984)
This commit removes support for s3 signer type in 6.0, and adds a note
to the migration guide.

closes #22599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.