Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the timeout of scroll requests #23268

Closed
jpountz opened this issue Feb 20, 2017 · 6 comments
Closed

Limit the timeout of scroll requests #23268

jpountz opened this issue Feb 20, 2017 · 6 comments

Comments

@jpountz
Copy link
Contributor

@jpountz jpountz commented Feb 20, 2017

Individual scrolls requests should be consumed quickly in order not to hold references on to old segments for too long. Right now we accept arbitrary timeouts but we should be more defensive and put a limit. 5 minutes should be plenty for everyone?

@nik9000

This comment has been minimized.

Copy link
Contributor

@nik9000 nik9000 commented Feb 20, 2017

@martinscholz83

This comment has been minimized.

Copy link
Contributor

@martinscholz83 martinscholz83 commented Feb 28, 2017

Hi @jpountz, what about this

public Scroll(StreamInput in) throws IOException {
        this.keepAlive = new TimeValue(in);
        if(keepAlive.seconds() > 300)
            throw new IllegalArgumentException("Keep alive time should be less than 5 minutes");
    }

    /**
     * Constructs a new scroll of the provided keep alive.
     */
    public Scroll(TimeValue keepAlive) {
        if(keepAlive.seconds() > 300)
            throw new IllegalArgumentException("Keep alive time should be less than 5 minutes");
        this.keepAlive = Objects.requireNonNull(keepAlive, "keepAlive must not be null");
    }
@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Mar 14, 2017

If the amount of data is too big, try to use Spark + ES.
but if it uses Spark, input-output ratio, may not be too high.

@pratiksanglikar

This comment has been minimized.

Copy link
Contributor

@pratiksanglikar pratiksanglikar commented Apr 12, 2017

Is anyone working on this issue?
If not, can I pick up this issue as my first contribution?

@abeyad

This comment has been minimized.

Copy link
Contributor

@abeyad abeyad commented Apr 12, 2017

@pratiksanglikar I don't believe anyone is currently working on it, you are welcome to pick this up. Thank you!

@pratiksanglikar

This comment has been minimized.

Copy link
Contributor

@pratiksanglikar pratiksanglikar commented Apr 12, 2017

@abeyad Thank you!
I'll pick up this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.