Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] org.elasticsearch.index.reindex.remote.RemoteRequestBuildersTests testInitialSearchParamsFields fails on 5.4 due to extra search params #24628

Closed
dakrone opened this issue May 11, 2017 · 1 comment

Comments

@dakrone
Copy link
Member

commented May 11, 2017

Seeing this failure:

java.lang.AssertionError: 
Expected: map containing ["fields"->"_source,_id,_parent,_routing,_ttl"]
     but: map was [<size=-1>, <fields=_source,_id,_parent,_routing,_ttl,_source>, <version=null>]
	at __randomizedtesting.SeedInfo.seed([AFFEEC0B404892D4:C8CC89B5649DFD1F]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:865)
	at org.junit.Assert.assertThat(Assert.java:832)
	at org.elasticsearch.index.reindex.remote.RemoteRequestBuildersTests.testInitialSearchParamsFields(RemoteRequestBuildersTests.java:136)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)

And it reproduces for me with:

gradle :modules:reindex:test -Dtests.seed=FDD4FBA1D902995D -Dtests.class=org.elasticsearch.index.reindex.remote.RemoteRequestBuildersTests -Dtests.method="testInitialSearchParamsFields" -Dtests.security.manager=true -Dtests.locale=da -Dtests.timezone=Asia/Pyongyang

Here's a failure log: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+5.4+multijob-windows-compatibility/85/console

@dakrone

This comment has been minimized.

Copy link
Member Author

commented May 11, 2017

Marked with awaitsfix in 7eaf201

nik9000 added a commit to nik9000/elasticsearch that referenced this issue May 11, 2017
If the request asks for the `_source` stored field then don't
duplicate it when forcing the `_source` parameter to onto the
request for reindex-from-remote from versions before 1.0.

Closes elastic#24628
nik9000 added a commit that referenced this issue May 11, 2017
If the request asks for the `_source` stored field then don't
duplicate it when forcing the `_source` parameter to onto the
request for reindex-from-remote from versions before 1.0.

Closes #24628
nik9000 added a commit that referenced this issue May 11, 2017
If the request asks for the `_source` stored field then don't
duplicate it when forcing the `_source` parameter to onto the
request for reindex-from-remote from versions before 1.0.

Closes #24628
@nik9000 nik9000 closed this in a40c3a9 May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.