Mapping: dynamic flag is explicitly returned even when not set #2789

kimchy opened this Issue Mar 16, 2013 · 1 comment


None yet
2 participants

kimchy commented Mar 16, 2013

When we rebuild the mappings based on dynamic additions of fields / wrappers, or explicitly, we set in the serialized form the dynamic field, even when its in its "default" set. We don't do that with other mappings, we should not do it with this one.

kimchy closed this in 111a132 Mar 16, 2013


s1monw commented Mar 16, 2013

;) thanks shay!

@pdegeus pdegeus added a commit to pdegeus/elasticsearch that referenced this issue Mar 20, 2013

@pdegeus pdegeus Merge branch 'master-upstream'
# By Shay Banon (43) and others
# Via Shay Banon
* master-upstream: (97 commits)
  better comment...
  if multicast socket closes, try and restart it also, throttle on socket failures, so it won't spin out of control... relates to #2783
  multicastSocket should be volatile as well...
  broadcast API to by default ignore missing / illegal shard state this happens for example because we list assigned shards, and they might not have been allocated on the relevant node yet, no need to list those as actual failures in some APIs
  upgrade to guava 14.0.1
  tar.gz distro by mistake include a windows lib
  fix javadoc
  Correct filter strategy opt: random_access_random to random_access_always
  Field Data: optimize long type to use narrowest possible type automatically closes #2795
  make ES compile with java 8 - that isAnnotationPresent bug is known, and probably will be fixed in later versions, but it costs us nothing to not use it now - some tests fail, mainly due to consistent ordering expected from Map (within versions) which does not seem to be preserved, need to fix those tests to be agnostic to it
  use ImmutableList.Builder instead of ArrayList
  fix logging message to include the index also add the list of current indices
  Mapping: dynamic flag is explicitly returned even when not set fixes #2789
  Fix bug in RateLimiter.SimpleRateLimiter causing numeric overflow in StoreStats
  improve TODO comment
  add CamelCase support to Suggester where missing
  Remove `sort_order` and `sort_mode` in favor of `order` and `mode`
  Add `sort_oder` and `sortOrder` as valid field names for defining the sort order in a Sort object.
  Make StupidBackoff the default smoothing model for phrase suggester
  minor cleanup suggest api - make sure we close the parser - fail when no content is provided in the rest request - reuse the suggest parse element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment