Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringTerms.Bucket.getKeyAsNumber should detect integers #28012

Closed
jpountz opened this issue Dec 28, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@jpountz
Copy link
Contributor

commented Dec 28, 2017

Currently it parses the string as a double, meaning it might lose accuracy if the value is an long which is greater than 2^52. We should try to detect whether the string represents a long or a double first.

@Chaycej

This comment has been minimized.

Copy link

commented Dec 28, 2017

I'll look into this issue.

@tehgoju

This comment has been minimized.

Copy link

commented Jan 5, 2018

@Chaycej are you planning to resolve this issue? If not, I'm willing to do this. :)

@matarrese

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2018

If someone is already working on this please ignore my pull request otherwise let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.