Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster level setting to control the max size of warning headers in client HTTP responses #28301

Closed
jasontedor opened this issue Jan 18, 2018 · 2 comments
Assignees
Labels
:Core/Infra/Core Core issues without another label >enhancement v6.3.0

Comments

@jasontedor
Copy link
Member

Today warning headers returned on client responses can be unbounded in size without a user knob to control this. Such warning headers can accumulate rapidly on, for example, bulk indexing requests using deprecated fields (e.g., string for keyword and text) across many fields. This can cause problems when there is a proxy between clients which limits the buffer size for proxy responses. This issue proposes adding a cluster level byte size setting that allows users to limit the size of warning headers sent on client HTTP responses. The default should be unbounded.

Relates #17804

@DaveCTurner
Copy link
Contributor

It's possible that the proxy rejects the headers because of their number rather than/as well as their total size. It might be useful to limit the number of headers too.

@kovyrin
Copy link

kovyrin commented Feb 15, 2018

Yes, please! We've just his this issue on Kibana/ES/ECE deployment, where ECE proxy chokes up on a bunch of warning coming from ES to Kibana and that basically made our Kibana permanently broken until we dropped the index that was generating warnings...

mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this issue Mar 9, 2018
…responses

Add a dynamic persistent cluster level setting "http.max_warning_header_count"
to control the maximum number of warning headers in client HTTP responses.
Defaults to unbounded.

Add a dynamic persistent cluster level setting "http.max_warning_header_size"
to control the maximum total size of warning headers in client HTTP responses.
Defaults to unbounded.

Closes elastic#28301
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this issue Mar 20, 2018
Add a dynamic persistent cluster level setting
"http.max_warning_header_count" to control the maximum number of
warning headers in client HTTP responses.
Defaults to unbounded.

Add a dynamic persistent cluster level setting
"http.max_warning_header_size" to control the maximum total size of
warning headers in client HTTP responses.
Defaults to unbounded.

Once any of these limits is exceeded this will be logged in the main
ES log, and any more warning headers for this response will be
ignored.

Closes elastic#28301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement v6.3.0
Projects
None yet
Development

No branches or pull requests

5 participants