Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopHitsAggregation should honor `index.max_result_window` #29190

Closed
jimczi opened this issue Mar 21, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@jimczi
Copy link
Member

commented Mar 21, 2018

We have an index setting that limits the number of top hits that can be retrieved in a single request.
By default it limits the from + size options to be less than 10,000. Though this limit is not applied to TopHitsAggregation which can use whatever size and from they want. We should check this setting and fail the query if the provided from + size are greater than this limit.

@jimczi

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2018

cc @elastic/es-search-aggs

@jimczi

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2018

This is already done in 6.1 with a new setting called index.max_inner_result_window which defaults to 100 per bucket, closing.

@jimczi jimczi closed this Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.