Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BalancedShardAllocator looses custom settings if un-related settings changed #2973

Closed
s1monw opened this Issue May 2, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@s1monw
Copy link
Contributor

commented May 2, 2013

The BalancedShardAllocator uses the default settings as the settings that are used if the relevant setting is not present in the settings object. Yet, this can cause lost settings in the allocator if the custom settings are not always passed in.

@ghost ghost assigned s1monw May 2, 2013

@s1monw s1monw closed this in 72982d9 May 2, 2013

s1monw added a commit that referenced this issue May 2, 2013

Use current settings as default in BalancedShardsAllocator instead of…
… defaults.

Custom settings are not always present in the `Settings` that are passed
to `NodeSettingsService.Listener#onRefreshSettings` such that using the defaults
will necessarily override the custom settings if set before.

Closes #2973

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Use current settings as default in BalancedShardsAllocator instead of…
… defaults.

Custom settings are not always present in the `Settings` that are passed
to `NodeSettingsService.Listener#onRefreshSettings` such that using the defaults
will necessarily override the custom settings if set before.

Closes elastic#2973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.