Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Analysis: Expose LimitTokenCountFilter in ElasticSearch #3013
I committed the code to my branch, but did not issue a pull request since I already have one open. Here is the commit:
I do not have a clean master and I do not want to rollback just to commit the previous commit to a different branch. I wish the ElasticSearch team would approve or decline pull requests. Mine is over a month old without a single comment.
hey @brusic I pulled your commit in and I will push in a bit. I am afraid sometimes PRs slip through and we try hard to get everything in that we can. Can you please ping on the PR you mentioned again to get my or others attention, thanks!
regarding open PRs you can have as many as you want with as many branches as you want if you need help with git, let me know I am working on a "how to contribute" guide and I am happy to share.
Thanks @s1monw for pushing out the change. My other pull request is a feature request that probably only affects myself and I have a workaround, so there is no urgency.
Ironically, I have been a strong advocate of switching to a DVCS here at work (preferably git, but I would accept bzr or mercurial) in order to get lightweight branching, and here I am not using branches properly! I will clean up my fork and submit another pull request with proper branches. Working on some other features as well.
As far as this issue goes, my commit used default values that helped thesuaves22's issue (from the mailing list), but are probably incorrect for general usage. I will match Solr's factory's handling of the args and submit a fix. Once that is submitted, I can add the filter to the docs as well.