Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis: Expose LimitTokenCountFilter in ElasticSearch #3013

Closed
thesuaves22 opened this Issue May 8, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@thesuaves22
Copy link

thesuaves22 commented May 8, 2013

Expose Lucene's LimitTokenCountFilter to ElasticSeach so we can pick the number of tokens to index on multi-valued data (array fields).

@brusic

This comment has been minimized.

Copy link
Contributor

brusic commented May 14, 2013

I committed the code to my branch, but did not issue a pull request since I already have one open. Here is the commit:
brusic@a52ba66

I do not have a clean master and I do not want to rollback just to commit the previous commit to a different branch. I wish the ElasticSearch team would approve or decline pull requests. Mine is over a month old without a single comment.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented May 14, 2013

hey @brusic I pulled your commit in and I will push in a bit. I am afraid sometimes PRs slip through and we try hard to get everything in that we can. Can you please ping on the PR you mentioned again to get my or others attention, thanks!

regarding open PRs you can have as many as you want with as many branches as you want if you need help with git, let me know I am working on a "how to contribute" guide and I am happy to share.

@ghost ghost assigned s1monw May 14, 2013

@s1monw s1monw closed this in 183ac1e May 14, 2013

s1monw added a commit that referenced this issue May 14, 2013

@brusic

This comment has been minimized.

Copy link
Contributor

brusic commented May 15, 2013

Thanks @s1monw for pushing out the change. My other pull request is a feature request that probably only affects myself and I have a workaround, so there is no urgency.

Ironically, I have been a strong advocate of switching to a DVCS here at work (preferably git, but I would accept bzr or mercurial) in order to get lightweight branching, and here I am not using branches properly! I will clean up my fork and submit another pull request with proper branches. Working on some other features as well.

As far as this issue goes, my commit used default values that helped thesuaves22's issue (from the mailing list), but are probably incorrect for general usage. I will match Solr's factory's handling of the args and submit a fix. Once that is submitted, I can add the filter to the docs as well.

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.