Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require acknowledgement/confirmation before starting trial license #30134

Closed
Tim-Brooks opened this issue Apr 25, 2018 · 5 comments
Closed

Require acknowledgement/confirmation before starting trial license #30134

Tim-Brooks opened this issue Apr 25, 2018 · 5 comments
Assignees
Labels
>bug :Security/License License functionality for commercial features v6.4.0 v7.0.0-beta1

Comments

@Tim-Brooks
Copy link
Contributor

Add the requirement that acknowledgement is passed in start_trial api. Additionally add acknowledgement messages when ack is not passed.

@Tim-Brooks Tim-Brooks added >bug v7.0.0 v6.3.0 :Security/License License functionality for commercial features labels Apr 25, 2018
@Tim-Brooks Tim-Brooks self-assigned this Apr 25, 2018
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this issue Apr 25, 2018
This is related to elastic#30134. It modifies the start_trial action to require
an acknowledgement parameter in the rest request to actually start the
trial license. There are backwards compatibility issues as prior ES
versions did not support this parameter. To handle this, it is assumed
that a request coming from a node prior to 6.3 is acknowledged. And
attempts to write a non-acknowledged request to a prior to 6.3 node will
throw an exception.

Additionally this PR adds messages about the trial license the user is
generating.
@hub-cap hub-cap added :Security/License License functionality for commercial features and removed :Security/License License functionality for commercial features labels Apr 25, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Tim-Brooks added a commit that referenced this issue Apr 27, 2018
This is related to #30134. It modifies the start_trial action to require
an acknowledgement parameter in the rest request to actually start the
trial license. There are backwards compatibility issues as prior ES
versions did not support this parameter. To handle this, it is assumed
that a request coming from a node prior to 6.3 is acknowledged. And
attempts to write a non-acknowledged request to a prior to 6.3 node will
throw an exception.

Additionally this PR adds messages about the trial license the user is
generating.
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this issue Apr 27, 2018
This is related to elastic#30134. It modifies the start_trial action to require
an acknowledgement parameter in the rest request to actually start the
trial license. There are backwards compatibility issues as prior ES
versions did not support this parameter. To handle this, it is assumed
that a request coming from a node prior to 6.3 is acknowledged. And
attempts to write a non-acknowledged request to a prior to 6.3 node will
throw an exception.

Additionally this PR adds messages about the trial license the user is
generating.
Tim-Brooks added a commit that referenced this issue Apr 27, 2018
This is related to #30134. It modifies the start_trial action to require
an acknowledgement parameter in the rest request to actually start the
trial license. There are backwards compatibility issues as prior ES
versions did not support this parameter. To handle this, it is assumed
that a request coming from a node prior to 6.3 is acknowledged. And
attempts to write a non-acknowledged request to a prior to 6.3 node will
throw an exception.

Additionally this PR adds messages about the trial license the user is
generating.
Tim-Brooks added a commit that referenced this issue Apr 27, 2018
This is related to #30134. It modifies the start_trial action to require
an acknowledgement parameter in the rest request to actually start the
trial license. There are backwards compatibility issues as prior ES
versions did not support this parameter. To handle this, it is assumed
that a request coming from a node prior to 6.3 is acknowledged. And
attempts to write a non-acknowledged request to a prior to 6.3 node will
throw an exception.

Additionally this PR adds messages about the trial license the user is
generating.
@jasontedor
Copy link
Member

@tbrooks8 I think that this is closed by #30198?

@Tim-Brooks
Copy link
Contributor Author

There is an open PR on master (#30218). But the 6.3 and 6.x work is complete.

@jasontedor
Copy link
Member

I missed that one; thanks for clarifying!

@Tim-Brooks
Copy link
Contributor Author

This is complete. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Security/License License functionality for commercial features v6.4.0 v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

6 participants