Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suggest API implementations pluggable #3089

Closed
spinscale opened this Issue May 24, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@spinscale
Copy link
Member

spinscale commented May 24, 2013

In order to create a foundation for more possible suggesters, we need to open up the suggest API and support the possibility of registering suggester types (similar to registering facets for example).

@ghost ghost assigned spinscale May 24, 2013

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented May 27, 2013

pull request looks awesome! maybe we can get a simple test for a "dummy" suggester that serves as an impl example for others?

spinscale added a commit to spinscale/elasticsearch that referenced this issue May 27, 2013

Make suggester implementation pluggable
This patch tries to make the suggester implementation as pluggable as
facets or highlight implementations. The goal is to be able to create
own suggest implementations in a suggest query.

Closes elastic#3089
@spinscale

This comment has been minimized.

Copy link
Member Author

spinscale commented May 27, 2013

Hey, I have pushed another version including tests and a dummy suggester

One more thing: Do you think it makes sense to create another kind of SuggestContext class as the only parameter for the Suggester.suggest() method?

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented May 27, 2013

@spinscale I think the current commit looks good! LGTM... push it!

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Jun 18, 2013

@spinscale any reason why this is not in 0.90? Can you backport it?

spinscale added a commit that referenced this issue Jun 24, 2013

Make suggester implementation pluggable
This patch tries to make the suggester implementation as pluggable as
facets or highlight implementations. The goal is to be able to create
own suggest implementations in a suggest query.

Closes #3089
@spinscale

This comment has been minimized.

Copy link
Member Author

spinscale commented Jun 24, 2013

@s1monw done

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Make suggester implementation pluggable
This patch tries to make the suggester implementation as pluggable as
facets or highlight implementations. The goal is to be able to create
own suggest implementations in a suggest query.

Closes elastic#3089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.