Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin manager #3112

Closed
inkblot opened this Issue May 29, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@inkblot
Copy link

inkblot commented May 29, 2013

I searched using Google and found nothing.

I tried this and got nothing:

$ ./plugin -help

I tried this and got nothing:

$ ./plugin -nonsense

I tried this and got incompete information:

$ ./plugin
Usage:
    -url     [plugin location]   : Set exact URL to download the plugin from
    -install [plugin name]       : Downloads and installs listed plugins
    -remove  [plugin name]       : Removes listed plugins
    -verbose                     : Prints verbose messages

I tried this and got nothing:

$ ./plugin -verbose

I tried this and got nothing:

$ ./plugin -verbose -nonsense

Just to make my own sense of frustrated indignation complete, I tried this:

$ ./plugin -this "is bullshit"
$ echo $?

The result was 0.

And the icing on the cake:

$ ./plugin -install
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1
        at org.elasticsearch.plugins.PluginManager.main(PluginManager.java:321)

I see lots of examples around the web where plugin name is something like mobz/elasticsearch-head or elasticsearch/mapper-attachments/1.6.0 which clearly has some semantically important syntax embedded in it. Nowhere is it documented what the components of this syntax are or what valid values are.

@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented May 29, 2013

Yeah. You're right.

Plugin could be used as follow:

  • site plugin (download master ZIP from github): bin/plugin -install username/reponame
  • elasticsearch official plugin (download from download.elasticsearch.org): bin/plugin -install elasticsearch/pluginname/version
  • community plugins (download from maven central): bin/plugin -install groupId/artifactId/version

We should fix that in documentation and as a default help as suggested.

@ghost ghost assigned dadoonet May 29, 2013

dadoonet added a commit to dadoonet/elasticsearch that referenced this issue May 30, 2013

Add more information and options in PluginManager
New option -l, --list displays list of existing plugins
New option -h, --help displays help
Deprecate options:
   -install is now -i, --install
   -remove is now -r, --remove
   -url is now -u, --url
Catch ArraysOutOfBoundException when no arg given to install, remove or url option
Add description on plugin name structure:
- elasticsearch/plugin/version for official elasticsearch plugins (download from download.elasticsearch.org)
- groupId/artifactId/version   for community plugins (download from maven central or oss sonatype)
- username/repository          for site plugins (download from github master)
Closes elastic#3112.

dadoonet added a commit that referenced this issue May 30, 2013

Add more information and options in PluginManager
New option -l, --list displays list of existing plugins
New option -h, --help displays help
Deprecate options:
   -install is now -i, --install
   -remove is now -r, --remove
   -url is now -u, --url
Catch ArraysOutOfBoundException when no arg given to install, remove or url option
Add description on plugin name structure:
- elasticsearch/plugin/version for official elasticsearch plugins (download from download.elasticsearch.org)
- groupId/artifactId/version   for community plugins (download from maven central or oss sonatype)
- username/repository          for site plugins (download from github master)
Closes #3112.

@dadoonet dadoonet closed this in 663f653 May 30, 2013

@dadoonet

This comment has been minimized.

Copy link
Member

dadoonet commented May 30, 2013

Now Plugin Manager does not send Exception and display documentation in case of error.
New options have been added:

  • -l, --list displays list of existing plugins
  • -h, --help displays help

Deprecated options:

  • -install is now -i, --install
  • -remove is now -r, --remove
  • -url is now -u, --url

Add description on plugin name structure:

  • elasticsearch/plugin/version for official elasticsearch plugins (download from download.elasticsearch.org)
  • groupId/artifactId/version for community plugins (download from maven central or oss sonatype)
  • username/repository for site plugins (download from github master)

ankon added a commit to Collaborne/elasticsearch-cloud-aws that referenced this issue Nov 11, 2014

ankon added a commit to Collaborne/elasticsearch-cloud-aws that referenced this issue Nov 12, 2014

Use the new 'install' form when invoking bin/plugin
'-install' was deprecated in elastic/elasticsearch#3112,
and 'install' is the proper variant from elastic/elasticsearch#7339.

tlrx added a commit to elastic/elasticsearch-cloud-aws that referenced this issue Nov 20, 2014

Use the new 'install' form when invoking bin/plugin
'-install' was deprecated in elastic/elasticsearch#3112,
and 'install' is the proper variant from elastic/elasticsearch#7339.

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Add more information and options in PluginManager
New option -l, --list displays list of existing plugins
New option -h, --help displays help
Deprecate options:
   -install is now -i, --install
   -remove is now -r, --remove
   -url is now -u, --url
Catch ArraysOutOfBoundException when no arg given to install, remove or url option
Add description on plugin name structure:
- elasticsearch/plugin/version for official elasticsearch plugins (download from download.elasticsearch.org)
- groupId/artifactId/version   for community plugins (download from maven central or oss sonatype)
- username/repository          for site plugins (download from github master)
Closes elastic#3112.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.