Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Version methods to be more readable #3124

Closed
spinscale opened this Issue May 31, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@spinscale
Copy link
Member

spinscale commented May 31, 2013

Current behaviour

Version.V_0_90_1.before(Version.V_0_90_0) == true

This is confusing and more readable the other way around.

Note: This is a breaking change! Test with care

Also all official plugins need to checked, in order to make sure, we use it right apart from elasticsearch core.

@ghost ghost assigned spinscale May 31, 2013

spinscale added a commit to spinscale/elasticsearch that referenced this issue May 31, 2013

Changing version semantics to be more readable
The Version class had hard to understand semantics when two versions were
compared against each other.

Sample of the new logic:
* V_0_20_0.before(V_0_90_0) => true
* V_0_90_0.after(V_0_20_0)  => true

Closes elastic#3124

@spinscale spinscale closed this in 609ad0e Jun 2, 2013

spinscale added a commit that referenced this issue Jun 2, 2013

Changing version semantics to be more readable
The Version class had hard to understand semantics when two versions were
compared against each other.

Sample of the new logic:
* V_0_20_0.before(V_0_90_0) => true
* V_0_90_0.after(V_0_20_0)  => true

Closes #3124

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Changing version semantics to be more readable
The Version class had hard to understand semantics when two versions were
compared against each other.

Sample of the new logic:
* V_0_20_0.before(V_0_90_0) => true
* V_0_90_0.after(V_0_20_0)  => true

Closes elastic#3124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.