Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVEL infinite loop in its error handling causing cluster to degrade #3168

Closed
nz opened this Issue Jun 12, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@nz
Copy link

nz commented Jun 12, 2013

Recently I've seen requests trigger a failure, where MVEL gets into an infinite loop trying to report the exception.

This failure causes service to degrade across the entire cluster, causing timeouts on requests handled by all nodes. These may be just for indexes with a shard on the affected machine, but it feels bigger than that.

Shared some logs and a repro with @kimchy.

@ghost ghost assigned bleskes Jun 18, 2013

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Jun 19, 2013

Based on @nz 's report, I've submitted a patch to MVEL to solve this issue (http://jira.codehaus.org/browse/MVEL-292 ) . It is limited in scope to a single line script that start with a new line and trigger an error while executing/parsing (this example, a bad field data access).

@bleskes bleskes closed this in 02c6222 Jun 19, 2013

bleskes added a commit that referenced this issue Jun 19, 2013

Trimming MVEL scripts before compiling them.
This bypasses an issue with MVEL error handling why can go into an infinite loop in some edge cases. More info here: http://jira.codehaus.org/browse/MVEL-292

Closes #3168

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Trimming MVEL scripts before compiling them.
This bypasses an issue with MVEL error handling why can go into an infinite loop in some edge cases. More info here: http://jira.codehaus.org/browse/MVEL-292

Closes elastic#3168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.