New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginManager fails with unknown command when passing url or verbose parameters #3245

Closed
sunriis opened this Issue Jun 26, 2013 · 5 comments

Comments

Projects
None yet
4 participants
@sunriis

sunriis commented Jun 26, 2013

To reproduce try:

bin/plugin -v

[...]

Message:
Command [-v] unknown.

The problem is that in the main function the commands are cycled twice; the first time to check for url and verbose, the second time to check for the others. If the second time a command that is not install, remove, list or help is found, the application exits (but url and verbose were never filtered out from the list of commands).

@ghost ghost assigned dadoonet Jun 26, 2013

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Jun 26, 2013

Member

Thanks for catching it! Working on a fix.

Member

dadoonet commented Jun 26, 2013

Thanks for catching it! Working on a fix.

@vpernin

This comment has been minimized.

Show comment
Hide comment
@vpernin

vpernin Jul 10, 2013

Are you going to release a 0.90.2.1 or 0.90.3 quickly with this fix ?

vpernin commented Jul 10, 2013

Are you going to release a 0.90.2.1 or 0.90.3 quickly with this fix ?

@dadoonet

This comment has been minimized.

Show comment
Hide comment
@dadoonet

dadoonet Jul 10, 2013

Member

You can install plugin manually by downloading and unzipping it in ./plugins/yourpluginname dir.
So even it's annoying, it's not a blocking issue and we don't need to release a new version just for that problem.

Member

dadoonet commented Jul 10, 2013

You can install plugin manually by downloading and unzipping it in ./plugins/yourpluginname dir.
So even it's annoying, it's not a blocking issue and we don't need to release a new version just for that problem.

@vpernin

This comment has been minimized.

Show comment
Hide comment
@vpernin

vpernin Jul 10, 2013

I know, I know ...

vpernin commented Jul 10, 2013

I know, I know ...

@missinglink

This comment has been minimized.

Show comment
Hide comment
@missinglink

missinglink Jul 10, 2013

Contributor

+1

Contributor

missinglink commented Jul 10, 2013

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment