New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behavior of doc_as_upsert is incorrect #3265

Closed
Paikan opened this Issue Jun 30, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@Paikan
Contributor

Paikan commented Jun 30, 2013

Here is the gist recreation

  • First some cleaning
$ curl -XDELETE 'localhost:9200/index1'
  • This insert the document where it shouldn't
$ curl -XPOST 'localhost:9200/index1/test1/1/_update' -d '
{
  doc : { field : "value" },
  doc_as_upsert : false 
}'
  • Changing the order change the behavior of the param
$ curl -XPOST 'localhost:9200/index1/test1/2/_update' -d '
{
  doc_as_upsert : false,
  doc : { field : "value" }
}'
@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Jun 30, 2013

Member

@Paikan Thanks for fixing this!

Member

martijnvg commented Jun 30, 2013

@Paikan Thanks for fixing this!

@Paikan

This comment has been minimized.

Show comment
Hide comment
@Paikan

Paikan Jun 30, 2013

Contributor

@martijnvg wow thanks it was fast! Shouldn't we push the fix in 0.90 branch too as I think the doc_as_upsert feature has been added in 0.90.2?

Contributor

Paikan commented Jun 30, 2013

@martijnvg wow thanks it was fast! Shouldn't we push the fix in 0.90 branch too as I think the doc_as_upsert feature has been added in 0.90.2?

@martijnvg

This comment has been minimized.

Show comment
Hide comment
@martijnvg

martijnvg Jun 30, 2013

Member

@Paikan Just pushed it also to the 0.90 branch. Took a while, the wifi on the train is a bit dodgy.

Member

martijnvg commented Jun 30, 2013

@Paikan Just pushed it also to the 0.90 branch. Took a while, the wifi on the train is a bit dodgy.

@Paikan

This comment has been minimized.

Show comment
Hide comment
@Paikan

Paikan Jun 30, 2013

Contributor

@martijnvg cool thanks and have a good end of trip then :)

Contributor

Paikan commented Jun 30, 2013

@martijnvg cool thanks and have a good end of trip then :)

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment