Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically updating index.gc_deletes not working #3396

Closed
sfussenegger opened this Issue Jul 26, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@sfussenegger
Copy link
Contributor

sfussenegger commented Jul 26, 2013

It seems that dynamically changing index.gc_deletes is broken. The corresponding field in code is RobinEngine.gcDeletesInMillis

this.gcDeletesInMillis = indexSettings.getAsTime(INDEX_GC_DELETES, TimeValue.timeValueSeconds(60)).millis();

It is only ever modified after a previous info log:

if (gcDeletesInMillis != RobinEngine.this.gcDeletesInMillis) {
     logger.info("updating index.gc_deletes from [{}] to [{}]", TimeValue.timeValueMillis(RobinEngine.this.gcDeletesInMillis), TimeValue.timeValueMillis(gcDeletesInMillis));
     RobinEngine.this.gcDeletesInMillis = gcDeletesInMillis;
}

This line never gets logged though.

Reopening the index works as expected.

@ghost ghost assigned bleskes Jul 26, 2013

@bleskes

This comment has been minimized.

Copy link
Member

bleskes commented Jul 26, 2013

@sfussenegger I fixed this recently in master as part of a bigger change. I will port that little fix to the 0.90 branch and it will be available in the next release.

bleskes added a commit that referenced this issue Jul 30, 2013

Ported an 0.90 branch excplicit test for dynamic update of gc_delete …
…setting for RobinEngine.

This issue is already solved in master.

See #3396

@bleskes bleskes closed this Jul 30, 2013

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.