Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on conflict execution of updates *within* bulk request was off by one #3447

Closed
bleskes opened this Issue Aug 6, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@bleskes
Copy link
Member

bleskes commented Aug 6, 2013

if the user set requestOnConflict to 3, we would only try again twice.

Note: this does not hold for normal updates.

@ghost ghost assigned bleskes Aug 6, 2013

@bleskes bleskes closed this in 43e374f Aug 6, 2013

bleskes added a commit that referenced this issue Aug 6, 2013

Maxing out retries on conflict in bulk update cause null pointer exce…
…ptions

Also:
Bulk update one less retry then requested
Document for retries on conflict says it default to 1 (but default is 0)
TransportShardReplicationOperationAction methods now catches Throwables instead of exceptions
Added a little extra check to UpdateTests.concurrentUpdateWithRetryOnConflict

Closes #3447 & #3448

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Maxing out retries on conflict in bulk update cause null pointer exce…
…ptions

Also:
Bulk update one less retry then requested
Document for retries on conflict says it default to 1 (but default is 0)
TransportShardReplicationOperationAction methods now catches Throwables instead of exceptions
Added a little extra check to UpdateTests.concurrentUpdateWithRetryOnConflict

Closes elastic#3447 & elastic#3448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.