Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest should ignore empty shards #3473

Closed
dadoonet opened this Issue Aug 9, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@dadoonet
Copy link
Member

dadoonet commented Aug 9, 2013

From #3469.
When running suggest on empty shards, it raises an error like:

"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]

We should ignore empty shards.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 14, 2013

@dadoonet what's the status of this?

@dadoonet

This comment has been minimized.

Copy link
Member Author

dadoonet commented Aug 14, 2013

Sorry Simon. Did not find time to integrate your comments. Will do before the end of this week.

@s1monw

This comment has been minimized.

Copy link
Contributor

s1monw commented Aug 14, 2013

thanks @dadoonet

dadoonet added a commit to dadoonet/elasticsearch that referenced this issue Aug 16, 2013

Suggest should ignore empty shards
From elastic#3469.
When running suggest on empty shards, it raises an error like:

```
"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]
```

We should ignore empty shards.

Closes elastic#3473.
@dadoonet

This comment has been minimized.

Copy link
Member Author

dadoonet commented Aug 16, 2013

@s1monw I created an AbstractSuggester class and kept the Suggester interface. Ok with that?

@dadoonet dadoonet closed this in ac06722 Aug 16, 2013

dadoonet added a commit that referenced this issue Aug 16, 2013

Suggest should ignore empty shards
From #3469.
When running suggest on empty shards, it raises an error like:

```
"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]
```

We should ignore empty shards.

Closes #3473.

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Suggest should ignore empty shards
From elastic#3469.
When running suggest on empty shards, it raises an error like:

```
"failures" : [ {
      "status" : 400,
      "reason" : "ElasticSearchIllegalArgumentException[generator field [title] doesn't exist]"
    } ]
```

We should ignore empty shards.

Closes elastic#3473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.