Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RestSearchAction#parseSearchXXX(RestRequest) public #3499

Closed
dadoonet opened this Issue Aug 13, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@dadoonet
Copy link
Member

dadoonet commented Aug 13, 2013

When building a plugin with a new search endpoint, you need to parse the request as a searchRequest.

Methods exist in RestSearchAction class but are private.

We will modify them to be public static. This applies to:

  • RestSearchAction#parseSearchRequest(RestRequest)
  • RestSearchAction#parseSearchSource(RestRequest)

@ghost ghost assigned dadoonet Aug 13, 2013

@dadoonet dadoonet closed this in 328608f Aug 13, 2013

dadoonet added a commit that referenced this issue Aug 13, 2013

Make RestSearchAction#parseSearchXXX(RestRequest) public
When building a plugin with a new search endpoint, you need to parse the request as a searchRequest.

Methods exist in RestSearchAction class but are private.

We will modify them to be public static. This applies to:

* `RestSearchAction#parseSearchRequest(RestRequest)`
* `RestSearchAction#parseSearchSource(RestRequest)`

 Closes #3499.

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Make RestSearchAction#parseSearchXXX(RestRequest) public
When building a plugin with a new search endpoint, you need to parse the request as a searchRequest.

Methods exist in RestSearchAction class but are private.

We will modify them to be public static. This applies to:

* `RestSearchAction#parseSearchRequest(RestRequest)`
* `RestSearchAction#parseSearchSource(RestRequest)`

 Closes elastic#3499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.