Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Manager can not download _site plugins from github #3551

Closed
dadoonet opened this Issue Aug 21, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@dadoonet
Copy link
Member

dadoonet commented Aug 21, 2013

Sounds like github changes a bit download url for master zip file.

From https://github.com/username/reponame/zipball/master to https://github.com/username/reponame/archive/master.zip.

We need to update plugin manager to reflect that change.

@ghost ghost assigned dadoonet Aug 21, 2013

@dadoonet dadoonet closed this in 8668479 Aug 21, 2013

dadoonet added a commit that referenced this issue Aug 21, 2013

Plugin Manager can not download _site plugins from github
Sounds like github changes a bit download url for master zip file.

From `https://github.com/username/reponame/zipball/master` to `https://codeload.github.com/username/reponame/zip/master`.

We need to update plugin manager to reflect that change.

In the meantime, we invite users having this issue to use:

```sh
bin/plugin -install reponame -url https://codeload.github.com/username/reponame/zip/master
```

For example:

```sh
bin/plugin -install paramedic -url https://codeload.github.com/karmi/elasticsearch-paramedic/zip/master
```

Closes #3551

dadoonet added a commit that referenced this issue Aug 21, 2013

Plugin Manager can not download _site plugins from github
Sounds like github changes a bit download url for master zip file.

From `https://github.com/username/reponame/zipball/master` to `https://github.com/username/reponame/archive/master.zip`.

We need to update plugin manager to reflect that change.

In the meantime, we invite users having this issue to use:

```sh
bin/plugin -install reponame -url https://github.com/username/reponame/archive/master.zip
```

For example:

```sh
bin/plugin -install paramedic -url https://github.com/karmi/elasticsearch-paramedic/archive/master.zip
```

Closes #3551
(cherry picked from commit 352d2aa)

dadoonet added a commit that referenced this issue Aug 21, 2013

Plugin Manager can not download _site plugins from github
Sounds like github changes a bit download url for master zip file.

From `https://github.com/username/reponame/zipball/master` to `https://github.com/username/reponame/archive/master.zip`.

We need to update plugin manager to reflect that change.

In the meantime, we invite users having this issue to use:

```sh
bin/plugin -install reponame -url https://github.com/username/reponame/archive/master.zip
```

For example:

```sh
bin/plugin -install paramedic -url https://github.com/karmi/elasticsearch-paramedic/archive/master.zip
```

Closes #3551
@dadoonet

This comment has been minimized.

Copy link
Member Author

dadoonet commented Aug 21, 2013

Commit updated thanks to @karmi!

karmi added a commit to elastic/cookbook-elasticsearch that referenced this issue Aug 22, 2013

@javanna

This comment has been minimized.

Copy link
Member

javanna commented Aug 27, 2013

It looks like the url user/repo/zipball/master is now working. It wasn't working back when this issue was opened, therefore we changed the github url where we get the archive from. Unfortunately the structure of the archive is slightly different when downloaded from the new url, since it contains a subfolder that has a slightly different naming, which we relied on in order to strip that part of the path from every zip entry and put all the files directly under the _site folder. To be more specific, the archives contain now a repo-master top-level folder, while using the other address the top-level folder is user-repo-hash.

We would like to keep the new adopted url format (user/repo/archive/master.zip) since it seems more future-proof, but we need to adapt the zip extraction process too in order for this to work properly.

Reopening this issue as I'm working it, a fix will follow.

@javanna javanna reopened this Aug 27, 2013

@javanna javanna closed this in d5b2c8e Aug 27, 2013

javanna added a commit that referenced this issue Aug 27, 2013

Fixed extraction of site plugins downloaded from github, so that we s…
…kip the top-level folder and we place the files directly under the _site folder

Closes #3551

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Plugin Manager can not download _site plugins from github
Sounds like github changes a bit download url for master zip file.

From `https://github.com/username/reponame/zipball/master` to `https://codeload.github.com/username/reponame/zip/master`.

We need to update plugin manager to reflect that change.

In the meantime, we invite users having this issue to use:

```sh
bin/plugin -install reponame -url https://codeload.github.com/username/reponame/zip/master
```

For example:

```sh
bin/plugin -install paramedic -url https://codeload.github.com/karmi/elasticsearch-paramedic/zip/master
```

Closes elastic#3551

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Plugin Manager can not download _site plugins from github
Sounds like github changes a bit download url for master zip file.

From `https://github.com/username/reponame/zipball/master` to `https://github.com/username/reponame/archive/master.zip`.

We need to update plugin manager to reflect that change.

In the meantime, we invite users having this issue to use:

```sh
bin/plugin -install reponame -url https://github.com/username/reponame/archive/master.zip
```

For example:

```sh
bin/plugin -install paramedic -url https://github.com/karmi/elasticsearch-paramedic/archive/master.zip
```

Closes elastic#3551
(cherry picked from commit 352d2aa)

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Fixed extraction of site plugins downloaded from github, so that we s…
…kip the top-level folder and we place the files directly under the _site folder

Closes elastic#3551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.