Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend named filter support to queries #3581

Closed
martijnvg opened this Issue Aug 27, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@martijnvg
Copy link
Member

martijnvg commented Aug 27, 2013

At moment the _name option is supported on all filters, and the search responses then indicates which filters that have the _name option have matched.

This name tagging should also be supported for queries. The matchedFilters will now also contain named queries and because of this the method naming in the Java apis have been changed to matchedQueries(...) instead of matchedFilters(...) in the SearchHit class. The matchedFilters(...) methods are still supported, but have been deprecated and will be removed in from version 1.0.Beta1.

@ghost ghost assigned martijnvg Aug 27, 2013

@martijnvg martijnvg closed this in 60ac34f Aug 28, 2013

martijnvg added a commit that referenced this issue Aug 28, 2013

Added `_name` support to queries.
This extends the named filter support from only filters to also queries.

Closes #3581

martijnvg added a commit that referenced this issue Sep 6, 2013

Deprecate the method names `namedFilter` in favor of `namedQueries`.
The reason behind this is that the `_name` support has been extended to queries as well and the name `namedQueries` suggests better that it is applicable to the whole query dsl.

Relates to #3581

martijnvg added a commit that referenced this issue Sep 6, 2013

Deprecate the method names `namedFilter` in favor of `namedQueries`.
The reason behind this is that the `_name` support has been extended to queries as well and the name `namedQueries` suggests better that it is applicable to the whole query dsl.

Relates to #3581

martijnvg added a commit that referenced this issue Sep 16, 2013

martijnvg added a commit that referenced this issue Sep 16, 2013

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Added `_name` support to queries.
This extends the named filter support from only filters to also queries.

Closes elastic#3581

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Deprecate the method names `namedFilter` in favor of `namedQueries`.
The reason behind this is that the `_name` support has been extended to queries as well and the name `namedQueries` suggests better that it is applicable to the whole query dsl.

Relates to elastic#3581

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.